Convert media action plugins to service provider #40169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandewt
reviewed
Mar 22, 2023
sandewt
reviewed
Mar 22, 2023
|
Incredibly powerful result with a system test. That's why I show the result here. How to get started with system tests can be found in this article https://github.com/joomla/joomla-cms/blob/4.4-dev/tests/System/README.md.
|
|
I have tested this item ✅ successfully on 6ecde3f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40169. |
heelc29
reviewed
Apr 1, 2023
heelc29
suggested changes
Apr 1, 2023
tests/System/integration/plugins/media-action/crop/CropPlugin.cy.js
Outdated
Show resolved
Hide resolved
tests/System/integration/plugins/media-action/resize/ResizePlugin.cy.js
Outdated
Show resolved
Hide resolved
tests/System/integration/plugins/media-action/rotate/RotatePlugin.cy.js
Outdated
Show resolved
Hide resolved
…cy.js Co-authored-by: heelc29 <[email protected]>
…gin.cy.js Co-authored-by: heelc29 <[email protected]>
…gin.cy.js Co-authored-by: heelc29 <[email protected]>
|
I have tested this item ✅ successfully on 739a92f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40169. |
|
I have tested this item ✅ successfully on 739a92f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40169. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40169. |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 4, 2023
2 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 30, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 9, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 23, 2023
laoneo
pushed a commit
that referenced
this pull request
May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146 * Add deleted files from #40180 and #40174 * Add deleted files from #39527 , #39535 , #40169 and #40173 * Add deleted files from #39552 , #39931 , #39628 and #40328 * Add deleted files from #40216 * Add deleted files from #40561 , #40190 and #40205
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 27, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 8, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 20, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Converts the media action plugins to service providers.
Testing Instructions
Edit an image in the media manager.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed