Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert mod_related_items to new structure #39628

Merged
merged 37 commits into from
Apr 24, 2023
Merged

Convert mod_related_items to new structure #39628

merged 37 commits into from
Apr 24, 2023

Conversation

carlitorweb
Copy link
Member

@carlitorweb carlitorweb commented Jan 14, 2023 •
edited
Loading

Summary of Changes

This PR converts mod_related_items to the new structure

Testing Instructions

  • Use Joomla 4.3
  • Create an instance of the module Articles Related. Note how it works.
  • Apply patch
  • Delete administrator/cache/autoload_psr4.php
  • Refresh the page, make sure the module still displays the same as before.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@carlitorweb carlitorweb requested a review from chmst as a code owner January 14, 2023 01:34
@carlitorweb carlitorweb force-pushed the convert_mod_related_items branch from 7d7fc38 to 4c91879 Compare January 22, 2023 02:40
@carlitorweb carlitorweb reopened this Jan 22, 2023
@richard67 richard67 mentioned this pull request Feb 18, 2023
Merged
2 tasks
@carlitorweb carlitorweb changed the base branch from 4.3-dev to 4.4-dev March 11, 2023 20:44
@Quy Quy removed the PR-4.3-dev label Mar 11, 2023
@laoneo laoneo self-assigned this Mar 20, 2023
@laoneo laoneo added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 29, 2023
@carlitorweb
Copy link
Member Author

@laoneo I revert the Helper in this one.

@laoneo laoneo added this to the Joomla! 4.4.0 milestone Apr 24, 2023
@laoneo laoneo enabled auto-merge (squash) April 24, 2023 15:27
@laoneo laoneo merged commit 8262060 into joomla:4.4-dev Apr 24, 2023
@laoneo
Copy link
Member

laoneo commented Apr 24, 2023

Thanks!

@carlitorweb carlitorweb deleted the convert_mod_related_items branch April 24, 2023 17:23
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
7e75033 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
218d9cb 
…oomla#40328
@richard67 richard67 mentioned this pull request May 1, 2023
Merged
2 tasks
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
9c7bc48 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
04e05c0 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
fbe3841 
…oomla#40328
laoneo pushed a commit that referenced this pull request May 23, 2023
@richard67
[4.4] Update deleted files list in script.php for 4.4.0-alpha1 (#40231)
deab947 
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b9590f5 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
ae4d12f 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
5ec80b1 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
e7877d8 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b956c59 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
fa06895 
…oomla#40328
@heelc29 heelc29 mentioned this pull request Jul 23, 2023
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
4949dc6 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
38d6e00 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
aab6e7b 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
0fb965f 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
5a56007 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b07bd79 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
b48a6b4 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
a3a1d8a 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
d9569b7 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
516ee41 
…oomla#40328
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
@richard67
Add deleted files from joomla#39552 , joomla#39931 , joomla#39628 and j…
2777b9b 
…oomla#40328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laoneo laoneo laoneo left review comments

@chmst chmst Awaiting requested review from chmst

Assignees

@laoneo laoneo

Labels
Feature PR-4.4-dev Unit/System Tests
Projects
None yet
Milestone
Joomla! 4.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@carlitorweb @laoneo @drmenzelit @Hackwar @Quy @joomla-cms-bot