Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mod_articles_archive to new structure #39535

Merged
merged 38 commits into from
Apr 3, 2023

Conversation

carlitorweb
Copy link
Member

@carlitorweb carlitorweb commented Jan 1, 2023

Summary of Changes

This PR converts mod_articles_archive to the new structure

Testing Instructions

  • Use Joomla 4.3
  • Create an instance of the module Articles - Archived. Note how it works.
  • Apply patch
  • Delete administrator/cache/autoload_psr4.php
  • Refresh the page, make sure the module still displays the same as before.

Additional comments

A small change to the layout was made. Now will show the amount of articles the month have archived, for example:

Before patch:
December, 2022

After patch:
December, 2022 (1)

If is not allowed, let me kown and I revert the change

@carlitorweb
Copy link
Member Author

@laoneo the name of the method getArticles() do not describe really the purpose of the method. Can be changed for this module to something like getMonths() for example?

@laoneo
Copy link
Member

laoneo commented Jan 3, 2023

Sure, change it. More accurate names are always better...

@carlitorweb carlitorweb changed the base branch from 4.3-dev to 4.4-dev March 11, 2023 20:47
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 4, 2023
@sandewt
Copy link
Contributor

sandewt commented Apr 4, 2023

Thanks for the hint, can you make a new pr for this?

I noticed even more details in the already modified modules. I think it would be useful to change those as well, so that they become more consistent. But first gain some more experience with the modules.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 30, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 9, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
laoneo pushed a commit that referenced this pull request May 23, 2023
* Add deleted files from #40066 , #40092 , #40142 and #40146

* Add deleted files from #40180 and #40174

* Add deleted files from #39527 , #39535 , #40169 and #40173

* Add deleted files from #39552 , #39931 , #39628 and #40328

* Add deleted files from #40216

* Add deleted files from #40561 , #40190 and #40205
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
muddygs added a commit to muddygs/joomla-claw-admin that referenced this pull request Feb 25, 2024
muddygs added a commit to muddygs/joomla-claw-admin that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants