Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Template layout select #30772

Merged
merged 1 commit into from
Sep 26, 2020
Merged

[4.0] Template layout select #30772

merged 1 commit into from
Sep 26, 2020

Conversation

brianteeman
Copy link
Contributor

If the label is "Fluid Layout" then the options should be "Yes/No"

But thats not very descriptive so this PR instead changes the label to "Layout" and keeps the options to "Fluid/Static"

Before

before

After

after

If the label is "Fluid Layout" then the options should be "Yes/No"

But thats not very descriptive so this PR instead changes the label to "Layout" and keeps the options to "Fluid/Static"
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 25, 2020
@toivo
Copy link
Contributor

toivo commented Sep 25, 2020

I have tested this item ✅ successfully on c1d3f9b

Tested successfully in Beta5-dev of 25 September.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30772.

@ChristineWk
Copy link

I have tested this item ✅ successfully on c1d3f9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30772.

@Quy Quy removed Language Change This is for Translators PR-4.0-dev labels Sep 25, 2020
@Quy
Copy link
Contributor

Quy commented Sep 25, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30772.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 25, 2020
@Quy Quy added the PR-4.0-dev label Sep 25, 2020
@Quy Quy added this to the Joomla 4.0 milestone Sep 26, 2020
@Quy Quy merged commit 2f40e16 into joomla:4.0-dev Sep 26, 2020
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels Sep 26, 2020
@Quy
Copy link
Contributor

Quy commented Sep 26, 2020

Thanks

dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 26, 2020
* Joomla/4.0-dev: (844 commits)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  Removing card.scss overrides as we don't use those classes
  Use renderField() method to render fields (joomla#30738)
  [4.0] spelling (joomla#30742)
  [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581)
  [4.0] Fix saving images (joomla#30730)
  [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729)
  Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710)
  [4.0] Fix Debug plugin to display query parameters (joomla#30717)
  ...
@brianteeman
Copy link
Contributor Author

thx

@brianteeman brianteeman deleted the rh10 branch September 26, 2020 23:08
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…ger_events_consistency

* '4.0-dev' of github.com:joomla/joomla-cms: (84 commits)
  [4.0] Error in legacy plugins when method contains $event argument (joomla#30575)
  [4.0] Cassiopea table css (joomla#30740)
  [4.0] Blog view links (joomla#30788)
  Change grid minmax definition for newsflash module (joomla#30781)
  [4.0] Pluginless lazyloading for the core (joomla#30748)
  Update package-lock.json (joomla#30713)
  [4.0] mod_article_news readmore (joomla#30780)
  Improve code, remove separator (joomla#30785)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  ...

� Conflicts:
�	administrator/components/com_media/resources/scripts/app/Api.js
�	administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue
�	package-lock.json
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
If the label is "Fluid Layout" then the options should be "Yes/No"

But thats not very descriptive so this PR instead changes the label to "Layout" and keeps the options to "Fluid/Static"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants