-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Wrap all buttons in btn-group to improve styling #30761
Conversation
spacing between items is out of scope for this pr |
Is it useful to display the Filter Button if
|
Also, for a11y, the table is missing something like
|
I have tested this item ✅ successfully on f7fc1bd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761. |
@Formatio-hippocampi |
@infograf768 Table Caption out of scope of this PR too... created new pr for it. #30763 |
I should have been more precise: |
@infograf768 adjusted PR. |
In a separate PR, filters section shouldn't be hidden when no items. |
I have tested this item ✅ successfully on f74fdb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761. |
1 similar comment
I have tested this item ✅ successfully on f74fdb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761. |
Tks. |
* Joomla/4.0-dev: (844 commits) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) Removing card.scss overrides as we don't use those classes Use renderField() method to render fields (joomla#30738) [4.0] spelling (joomla#30742) [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581) [4.0] Fix saving images (joomla#30730) [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729) Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710) [4.0] Fix Debug plugin to display query parameters (joomla#30717) ...
…ger_events_consistency * '4.0-dev' of github.com:joomla/joomla-cms: (84 commits) [4.0] Error in legacy plugins when method contains $event argument (joomla#30575) [4.0] Cassiopea table css (joomla#30740) [4.0] Blog view links (joomla#30788) Change grid minmax definition for newsflash module (joomla#30781) [4.0] Pluginless lazyloading for the core (joomla#30748) Update package-lock.json (joomla#30713) [4.0] mod_article_news readmore (joomla#30780) Improve code, remove separator (joomla#30785) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) ... � Conflicts: � administrator/components/com_media/resources/scripts/app/Api.js � administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue � package-lock.json
* wrap all buttons in btn-group to improve styling * add if-then statement to hide button if not needed
Pull Request for Issue #29504 .
Summary of Changes
This pr will put elements in horizontal line
Testing Instructions
Joomla 4 with "Testing Sample Data"
url => index.php/recipes
Actual result BEFORE applying this Pull Request
See screenshot in #29504
Expected result AFTER applying this Pull Request
Documentation Changes Required