Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Wrap all buttons in btn-group to improve styling #30761

Merged
merged 2 commits into from
Sep 26, 2020

Conversation

hans2103
Copy link
Contributor

Pull Request for Issue #29504 .

Summary of Changes

This pr will put elements in horizontal line

Testing Instructions

Joomla 4 with "Testing Sample Data"
url => index.php/recipes

Actual result BEFORE applying this Pull Request

See screenshot in #29504

Expected result AFTER applying this Pull Request

Schermafbeelding 2020-09-25 om 08 53 05

Documentation Changes Required

@hans2103
Copy link
Contributor Author

spacing between items is out of scope for this pr

@infograf768
Copy link
Member

infograf768 commented Sep 25, 2020

Is it useful to display the Filter Button if filter-field is set to hide?
I suggest to modify that part to

			<?php if ($this->params->get('filter_field') !== 'hide') : ?>
				<div class="com-content-category__filter-submit control-group hidden-xs-up float-right">
					<div class="controls">
						<button type="submit" name="filter_submit" class="btn btn-primary"><?php echo Text::_('COM_CONTENT_FORM_FILTER_SUBMIT'); ?></button>
					</div>
				</div>
			<?php endif; ?>

@infograf768
Copy link
Member

Also, for a11y, the table is missing something like

<caption id="captionTable" class="sr-only">
					<?php echo Text::_('COM_CONTENT_ARTICLES_TABLE_CAPTION'); ?>,
				</caption>

@ghost
Copy link

ghost commented Sep 25, 2020

I have tested this item ✅ successfully on f7fc1bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.

@infograf768
Copy link
Member

infograf768 commented Sep 25, 2020

@Formatio-hippocampi
Please wait for @hans2103 to take care of my comments. :)

@hans2103
Copy link
Contributor Author

@infograf768
I don't know if it is useful to display the Filter Button if filter-field is set to hide?
I haven't looked into the functionality of the rendered fields nor buttons. This is not the scope of this PR.

Table Caption out of scope of this PR too... created new pr for it. #30763

@infograf768
Copy link
Member

I should have been more precise:
The Filter button IS useless when filter-field is set to hide...

@hans2103
Copy link
Contributor Author

@infograf768 adjusted PR.
Actually you are saying that a PR was needed anyway to solve the display of the button? Not only to fix alignment

@hans2103 hans2103 changed the title wrap all buttons in btn-group to improve styling [4.0] Wrap all buttons in btn-group to improve styling Sep 25, 2020
@Quy
Copy link
Contributor

Quy commented Sep 25, 2020

In a separate PR, filters section shouldn't be hidden when no items.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on f74fdb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Sep 25, 2020

I have tested this item ✅ successfully on f74fdb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.

@Quy
Copy link
Contributor

Quy commented Sep 25, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30761.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 25, 2020
@infograf768 infograf768 merged commit c0592e2 into joomla:4.0-dev Sep 26, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 26, 2020
@infograf768
Copy link
Member

Tks.

@infograf768 infograf768 added this to the Joomla 4.0 milestone Sep 26, 2020
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 26, 2020
* Joomla/4.0-dev: (844 commits)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  Removing card.scss overrides as we don't use those classes
  Use renderField() method to render fields (joomla#30738)
  [4.0] spelling (joomla#30742)
  [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581)
  [4.0] Fix saving images (joomla#30730)
  [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729)
  Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710)
  [4.0] Fix Debug plugin to display query parameters (joomla#30717)
  ...
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…ger_events_consistency

* '4.0-dev' of github.com:joomla/joomla-cms: (84 commits)
  [4.0] Error in legacy plugins when method contains $event argument (joomla#30575)
  [4.0] Cassiopea table css (joomla#30740)
  [4.0] Blog view links (joomla#30788)
  Change grid minmax definition for newsflash module (joomla#30781)
  [4.0] Pluginless lazyloading for the core (joomla#30748)
  Update package-lock.json (joomla#30713)
  [4.0] mod_article_news readmore (joomla#30780)
  Improve code, remove separator (joomla#30785)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  ...

� Conflicts:
�	administrator/components/com_media/resources/scripts/app/Api.js
�	administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue
�	package-lock.json
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* wrap all buttons in btn-group to improve styling

* add if-then statement to hide button if not needed
@hans2103 hans2103 deleted the patch-8 branch November 24, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants