Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] spelling #30742

Merged
merged 1 commit into from
Sep 23, 2020
Merged

[4.0] spelling #30742

merged 1 commit into from
Sep 23, 2020

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Sep 23, 2020

fix my own mistake the correct spelling is fulfil

Pull Request for Issue #30741

fix my own mistake the correct spelling is fulfil
@richard67
Copy link
Member

richard67 commented Sep 23, 2020

I have tested this item ✅ successfully on 0380595

Checked that this PR covers all occurrences of fulfill in comments in PHP files which we can change.

The lots of other places where it can be found belong to vendor libraries, so we shouldn't touch them. Silly me, ain't in the sources anyway on J4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30742.

@alikon
Copy link
Contributor

alikon commented Sep 23, 2020

I have tested this item ✅ successfully on 0380595

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30742.

@alikon
Copy link
Contributor

alikon commented Sep 23, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30742.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 23, 2020
@Quy Quy added this to the Joomla 4.0 milestone Sep 23, 2020
@wilsonge wilsonge merged commit 74c6d06 into joomla:4.0-dev Sep 23, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 23, 2020
@brianteeman
Copy link
Contributor Author

thanks - but it was my mistake in the first place :(

@brianteeman brianteeman deleted the rh7 branch September 23, 2020 20:24
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 26, 2020
* Joomla/4.0-dev: (844 commits)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  Removing card.scss overrides as we don't use those classes
  Use renderField() method to render fields (joomla#30738)
  [4.0] spelling (joomla#30742)
  [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581)
  [4.0] Fix saving images (joomla#30730)
  [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729)
  Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710)
  [4.0] Fix Debug plugin to display query parameters (joomla#30717)
  ...
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
fix my own mistake the correct spelling is fulfil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants