onUserLoginFailure needs to catch failure to write to log file during failed login

[GeraintEdwards]

Pull Request for Issue #11869

Summary of Changes

Added Try/Catch around the call to JLog::add so that failed attempt to login doesn't throw unhelpful error screen but instead returns visitor to login page as they would if the log file was writeable.

Testing Instructions

Install patch
Login in the backend with incorrect password or missing password

Expected result

return to login page with message about failure to login

Actual result

Now it does this instead of the error page with message about failure to write to log file

Documentation Changes Required

none

[mbabker]

This just needs the code style issues to be addressed (we use tabs instead of spaces), otherwise looks good to me. Thanks!

[carcam]

I have tested this item ✅ successfully on 2053caa

Now Joomla! redirects to the backend login page and shows the errors in the messages area above the login form.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16475.}

[brianteeman]

I have tested this item ✅ successfully on 2053caa

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16475.}

[ghost]

RTC after two successful tests.