Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can login at back-end if the password is wrong. #11869

Closed
bhavikpatel10 opened this issue Sep 1, 2016 · 7 comments
Closed

User can login at back-end if the password is wrong. #11869

bhavikpatel10 opened this issue Sep 1, 2016 · 7 comments

Comments

@bhavikpatel10
Copy link

bhavikpatel10 commented Sep 1, 2016

Steps to reproduce the issue

  • Do not give write permission to log file.
  • Trying to login at the back-end using wrong password and correct username.
  • There will be error message that, Cannot write to log file.
  • At the top right corner, you can see user is logged-in in the site, which is not correct, because the password is wrong.

Expected result

User can not access site with wrong password and stay at the login page.

Actual result

Use can login with wrong password.

System information (as much as possible)

Additional comments

screen shot 2016-09-01 at 00 11 24

@hacki65
Copy link
Contributor

hacki65 commented Sep 1, 2016

I can confirm this. But this seems to be the normal Errorpage from Joomla! for these cases and it is confusing. But no User is really logged in and any action will bring back to the Loginpage.

@ghost
Copy link

ghost commented Sep 1, 2016

One could add a cosmetical

<?php if (!empty($user->id)) : ?>
 <ul class="nav nav-user<?php echo ($this->direction == 'rtl') ? ' pull-left' : ' pull-right'; ?>">
....
 </ul>
<?php endif; ?>

in templates/isis/error.php line 162.

@brianteeman
Copy link
Contributor

This is a bug and needs fixing. The behaviour should be the same as if the logs file is writeable .

Thanks for reporting it

@mbabker
Copy link
Contributor

mbabker commented Sep 1, 2016

The bug is just as @hacki65 pointed out, the error page is basically unaware of the user state. Since the Isis error page tries to mimic the base template layout, it has to have additional checks to be aware of user state. The Hathor error page doesn't do this.

@GeraintEdwards
Copy link
Contributor

GeraintEdwards commented Jun 3, 2017

It appears to still be an issue in version 3.7.2.

The login script should catch the exception from the logger and return the visitor to the login page. I will implement this and post a PR.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/11869

@ghost
Copy link

ghost commented Jun 3, 2017

closed as having PR #16475


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11869.

wilsonge pushed a commit that referenced this issue Jun 6, 2017
… failed login (#16475)

* Catch failure to write log file during failed login
fixes issue #11869

* change spaces to tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants