Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onUserLoginFailure needs to catch failure to write to log file during failed login #16475

Merged
merged 3 commits into from
Jun 6, 2017
Merged

onUserLoginFailure needs to catch failure to write to log file during failed login #16475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561117e
Catch failure to write log file during failed login
Jun 3, 2017
453742e
Merge branch 'staging' of https://github.com/joomla/joomla-cms into b…
Jun 3, 2017
2053caa
change spaces to tabs
Jun 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion plugins/system/log/log.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ public function onUserLoginFailure($response)
}

JLog::addLogger(array(), JLog::INFO);
JLog::add($errorlog['comment'], JLog::INFO, $errorlog['status']);
try
{
JLog::add($errorlog['comment'], JLog::INFO, $errorlog['status']);
}
catch (Exception $e)
{
// If the log file is unwriteable during login then we should not go to the error page
return;
}
}
}