[com_fields] Change extension variable to context for custom field groups #13175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some background to explain why I chose "extension" instead of "context" for the groups:
So imho we should change all "context" to "extension" but Allon disagrees with me here 😄 |
Bakual
reviewed
Dec 13, 2016
| @@ -197,7 +204,7 @@ protected function getSortFields() | |||
| 'a.title' => JText::_('JGLOBAL_TITLE'), | |||
| 'a.access' => JText::_('JGRID_HEADING_ACCESS'), | |||
| 'language' => JText::_('JGRID_HEADING_LANGUAGE'), | |||
| 'a.extension' => JText::_('JGRID_HEADING_EXTENSION'), | |||
| 'a.context' => JText::_('JGRID_HEADING_context'), | |||
There was a problem hiding this comment.
JGRID_HEADING_contextShould be all uppercase here.
Bakual
reviewed
Dec 13, 2016
| * @copyright Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
| defined('_JEXEC') or die; | ||
|
|
||
| $app = JFactory::getApplication(); | ||
| $component = $app->getUserStateFromRequest('com_fields.groups.extension', 'extension', '', 'CMD'); | ||
| $context = $app->getUserStateFromRequest('com_fields.groups.context', 'context', '', 'CMD'); | ||
| $component = ''; |
There was a problem hiding this comment.
$component isn't populated here and thus the ACL check will break.
Best is probably to move the explode part out of the if clause to the line just before the ACL check.
|
I have tested this item ✅ successfully on 8a7f5b0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13175. |
|
I have tested this item ✅ successfully on 8a7f5b0 Amazing progress! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13175. |
|
RTC based on 2 successful tests This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13175. |
|
Thanks to the testers! |
Bakual
pushed a commit
that referenced
this pull request
Jan 7, 2017
* MSSQL - update sql for Custom fields (#11833) MSSQL - update sql for Custom fields (#11833) * MSSQL - update sql for Custom fields (#11833) MSSQL - update sql for Custom fields (#11833) * MSSQL - install sql for Custom fields (#11833) MSSQL - install sql for Custom fields (#11833) * minor cs + defaul values * move hits field on a new line move hits field on a new line * removed version, hits fields removed (version, hits) fields #12674 * removed (version,hits) fields removed (version,hits) fields #12674 * mssql com_fields#13091 Fixing sql fields #13091 * mssql com_fields#13091 mssql com_fields#13091 * [com_fields] No need for an alias in fields groups. #13115 [com_fields] No need for an alias in fields groups. #13115 * [com_fields] No need for an alias in fields groups. #13115 [com_fields] No need for an alias in fields groups. #13115 * missed comma missed comma * missed comma missed comma * update for #13175 from extension to context * update for #13175 from extension to context * update for #13246 update for #13246 * updated for #13246 updated for #13246 * added the missed DEFAULT added the missed DEFAULT * added space before ( added space before ( * added space before ( added space before (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The new field groups (#13019) are created globally per component. It means when a component has more than one context, it is not possible to create groups per context. This pr solves that and allows to create groups per context of fields. A field belongs to a context and with this pr the group as well.
It fixes also an issue where a second asset per group is created when a permission has changed.
Testing Instructions
After a fresh installation, create groups, assign fields to them. All should work as before.
A fresh installation is needed as the database schema has changed..