[com_fields] MSSQL - sql for Custom fields

[alikon]

Pull Request for Issue #12624 .

Summary of Changes

• MSSQL - update sql for Custom fields (Custom fields #11833)
• MSSQL - install sql for Custom fields (Custom fields #11833)
• MSSQL - update sql for Custom fields (Fixing sql fields #13091)
• MSSQL - install sql for Custom fields (Fixing sql fields #13091)
• MSSQL - update sql for Custom fields ([com_fields] No need for an alias in fields groups. #13115)
• MSSQL - install sql for Custom fields ([com_fields] No need for an alias in fields groups. #13115)
• MSSQL - update sql for Custom fields ([com_fields] Change extension variable to context for custom field groups #13175)
• MSSQL - install sql for Custom fields ([com_fields] Change extension variable to context for custom field groups #13175)
• MSSQL - update sql for Custom fields ([com_fields] Normalise data structure for assigned categories #13246)
• MSSQL - install sql for Custom fields ([com_fields] Normalise data structure for assigned categories #13246)

[zero-24]

@alikon this just includes the update part is that correct / expected?

Also this is all in one line? is this expected too?

[alikon]

No, I'm having big connection issues, hope to solve soon i'll put install
file too, sorry...

On 31 Oct 2016 3:15 pm, "zero-24" [email protected] wrote:

@alikon https://github.com/alikon this jjust includes the update part
is that correct / expected?

Also this is all in one line? is this expected too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12660 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFseYWgpypxgDH7RwRdfDNjlLpPyDyks5q5fgQgaJpZM4KlDXf
.

[zero-24]

no problem. Thanks!

[andrepereiradasilva]

@alikon can you please add line endings

[alikon]

@andrepereiradasilva I'll complete this pr when I regain a stable
connection ;)

On 31 Oct 2016 3:57 pm, "andrepereiradasilva" [email protected]
wrote:

@alikon https://github.com/alikon can you please add line endings

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12660 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsVWAyEckp3pUJLs7zA2hYZ04JP4wks5q5f2vgaJpZM4KlDXf
.

[alikon]

can someone do a review or a test on MSSQL (cause i don't have a mssql environment available)

[laoneo]

Had a discussion with @matrikular about the MSSQL scripts. Perhaps he can test it as well.

[alikon]

updated for #13091

[laoneo]

Can you add the "[com_fields]" to the beginning of the title? People start asking about open pull requests and I'm telling them that they have to search for com_fields. Thanks.

[Bakual]

Adjusted the title

[alikon]

updated for #13246

[csthomas]

I have tested it on backend and it is OK.

Why there is a few difference between sql install and update file?

[zero-24]

The install and update file need to be equal as we need everything (tables etc.) also on sites that got updated to 3.7.0 :)

[alikon]

fixed the missed default

[csthomas]

After I patched by Patch Tester a see (it is incorrect - table name should not contain column name):

Table 'j37_fields( id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'j37_fields_categories(  field_id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'j37_fields_groups( id' does not exist. (From file 3.7.0-2016-08-29.sql.)
Table 'j37_fields_values( field_id' does not exist. (From file 3.7.0-2016-08-29.sql.)

After I click FIX the tables are created and fields work OK.

But I still see above warnings.

Please add white space before '(':

CREATE TABLE [#__fields](

replace to:

CREATE TABLE [#__fields] (

and for others "CREATE TABLE" do the same.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12660.}

[alikon]

@csthomas added the space, but all other existing CREATE TABLE don't have that space
anyway thanks for testing

[csthomas]

I have tested this item ✅ successfully on 6fad1a2

Because of some regex in component installer for database fix "CREATE TABLE" requires space.
It is only needed in update sql files:)

Success.

Database schema version (in #__schemas): 3.7.0-2016-11-24.
Update version (in #__extensions): 3.7.0-alpha2.
Database driver: sqlsrv.
12 database changes were checked successfully.
225 database changes did not alter table structure and were skipped.

Because the last three commits add only white spaces and " DEFAULT ''" which exists in the install sql file
IMO it can be merged without additional test.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12660.}

[alikon]

Because of some regex in database fix in component installer "CREATE TABLE" requires space.
It is only needed in update sql files

we need to remeber this when we will update some others on MSSQL

[laoneo]

Can a maintainer set this to RTC as we have a successful test on MSSQL.

Good work guys!

[laoneo]

There will be some more work then when pr #13319 got merged. But let's get this one in first.

[infograf768]

We have only one test as #12660 (comment) was done before changes

[laoneo]

Honestly I'm not sure if we will find two testers for this.

[waader]

I will test this one later today.

[alikon]

thanks @waader

[waader]

I have tested this item ✅ successfully on 6fad1a2

I tested the backend with content, users and contacts and it works. Frontend is currently broken which has nothing to do with this patch. With a rudimentary fix I could get it working also in frontend.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12660.}

[csthomas]

You can try to test front end with applied #13262

[waader]

I also did that, but it didn´t work.

[laoneo]

Thanks for all the work guys!! Ready for RTC.

[jeckodevelopment]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12660.}