Fixing sql fields #13091
Merged
Fixing sql fields #13091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2016 13:36
Added missing PostgreSQL ALTER statement.
alikon
reviewed
Dec 5, 2016
| "access" bigint DEFAULT 0 NOT NULL, | ||
| PRIMARY KEY ("id") | ||
| ); | ||
| CREATE INDEX "#__fields_idx_checked_out" ON "#__fields_groups" ("checked_out"); |
There was a problem hiding this comment.
sql CREATE INDEX "#__fields_idx_checked_out" ON "#__fields_groups" ("checked_out");
cannot see a checked_out field on #__fields_group table declaration
There was a problem hiding this comment.
seems missed from mysql table declaration
There was a problem hiding this comment.
Indeed missed those on the update files. Do you want to do the PR or should I do it?
There was a problem hiding this comment.
isn't better to revert+fix+remerge ?
There was a problem hiding this comment.
Nah, we just can add those two columns in a different PR.
This was referenced Dec 5, 2016
Bakual
pushed a commit
that referenced
this pull request
Jan 7, 2017
* MSSQL - update sql for Custom fields (#11833) MSSQL - update sql for Custom fields (#11833) * MSSQL - update sql for Custom fields (#11833) MSSQL - update sql for Custom fields (#11833) * MSSQL - install sql for Custom fields (#11833) MSSQL - install sql for Custom fields (#11833) * minor cs + defaul values * move hits field on a new line move hits field on a new line * removed version, hits fields removed (version, hits) fields #12674 * removed (version,hits) fields removed (version,hits) fields #12674 * mssql com_fields#13091 Fixing sql fields #13091 * mssql com_fields#13091 mssql com_fields#13091 * [com_fields] No need for an alias in fields groups. #13115 [com_fields] No need for an alias in fields groups. #13115 * [com_fields] No need for an alias in fields groups. #13115 [com_fields] No need for an alias in fields groups. #13115 * missed comma missed comma * missed comma missed comma * update for #13175 from extension to context * update for #13175 from extension to context * update for #13246 update for #13246 * updated for #13246 updated for #13246 * added the missed DEFAULT added the missed DEFAULT * added space before ( added space before ( * added space before ( added space before (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #13088.
Summary of Changes
Testing Instructions
Documentation Changes Required
None
Notes
Once this is merged, fields still need SQL Azure SQL commands.