Question: start jar numbering at 1?

[dergigi]

Currently, the default of 5 jars is displayed as follows:

• Jar #0
• Jar #1
• Jar #2
• Jar #3
• Jar #4

While this is in accordance to JoinMarket internals, and fine for nerds and computer science people, it's probably confusing for newcomers.

Question: should we use the more natural numbering of 1 to 5?

• Jar #1
• Jar #2
• Jar #3
• Jar #4
• Jar #5

I'm talking about a change in the user-facing UI only, internally numbering will start at zero, of course.

[ghost]

Definitely start at 1! 👍

We just have to be careful to not confuse our UI indexes with the actual ones. Sweeping the forth (zero-indexed) jar when the user actually wanted to sweep the third one would be bad. 😅

[stachrom]

I would strongly suggest to keep the Numbers:
Jar #0
Jar #1
Jar #2
Jar #3
Jar #4

If we disconnect from the internal numbering - i fear truble.

Every now and than you need to go back to the cli and there you will find the "first Jar" is labeled as 0.
https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/USAGE.md#funding-wallet-and-displaying-balance

[dergigi]

Every now and than you need to go back to the cli

That might be true now, but I hope that it won't be true in the future. Hmm. 🤔

[ghost]

Closing this in favor of #435.