Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: display spendable amount on Send page #4

Closed
wants to merge 2 commits into from
Closed

WIP: feat: display spendable amount on Send page #4

wants to merge 2 commits into from

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Jan 4, 2022

Display spendable amount on the Send page.

Gotchas:

  • Some utxos can be auto-frozen by jm. These are not spendable and cannot be "unfrozen" via the api at the moment.
    How should this be displayed to the user?

Still todo:

  • reload available balances after payment

@dergigi
Copy link
Contributor

dergigi commented Jan 28, 2022

I'll review and test this PR as soon as the conflict is resolved.

@theborakompanioni
Copy link
Collaborator Author

I'll review and test this PR as soon as the conflict is resolved.

I am not happy with the approach here.

The thing is.. should we even try to determine the "spendable" amount in the ui?
It'd be good to get this value from the server, as any changes in the mechanism would make our calculations obsolete, maybe plain wrong.

@dergigi
Copy link
Contributor

dergigi commented Feb 1, 2022

It'd be good to get this value from the server, as any changes in the mechanism would make our calculations obsolete, maybe plain wrong.

Agree, let's not do it client-side.

@ghost
Copy link

ghost commented Feb 2, 2022

It'd be good to get this value from the server, as any changes in the mechanism would make our calculations obsolete, maybe plain wrong.

Yeah that probably make sense! I'm closing this PR then, feel free to reopen if needed.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed 🚫
Development

Successfully merging this pull request may close these issues.

2 participants