Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept: named jars (orange, strawberry, etc.) #435

Closed
dergigi opened this issue Aug 1, 2022 · 15 comments · Fixed by #476
Closed

Concept: named jars (orange, strawberry, etc.) #435

dergigi opened this issue Aug 1, 2022 · 15 comments · Fixed by #476
Assignees
Labels
concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience

Comments

@dergigi
Copy link
Contributor

dergigi commented Aug 1, 2022

As discussed in Community Call 20. Related to #416.


2022-07-04: Updated suggestion, again from Jar 0 to Jar 4:

  • A = Apricot 🟠
  • B = Blueberry 🔵
  • C = Cherry 🔴
  • D = Date 🟤
  • E = Elderberry 🟣

Benefit: Nicely maps 0-1-2-3-4 to A-B-C-D-E, removing the "nerd numbering" that starts with zero, without introducing additional confusion that would arise from switching to 1-2-3-4-5 (because JoinMarket still uses 0-1-2-3-4).


Previous suggestion, from Jar 0 to Jar 4:

  • Orange 🟠
  • Strawberry 🔴
  • Grape 🟢
  • Blueberry 🔵
  • Plum 🟣

Fruits are picked randomly, somwhat.1 (Tried to pick some that would map nicely to colors. Color accents should be very subtle, if present at all, to not confuse users with 'green is good' or 'red is bad'.)

Footnotes

  1. https://www.statista.com/statistics/280744/us-households-most-eaten-flavors-of-jams-jellies-and-preserves-trend/

@dergigi dergigi added concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience labels Aug 1, 2022
@dergigi
Copy link
Contributor Author

dergigi commented Aug 4, 2022

Added an updated suggestion to use A-B-C-D-E instead of numbers.

@ghost
Copy link

ghost commented Aug 4, 2022

Letters instead of numbers are great! Gets rid of the awkward 0-index while keeping the mapping to the number-indexed mixdepths on the CLI reasonable.

Quick mockup just to help people visualize it:

Screenshot 2022-08-04 at 11 39 33

Obviously we'd have to find a nicely looking color scheme. This is just something quick from coolors.co. Maybe a fruit that starts with a C that's not red 🔴 would be nice. The red looks quite dangerous here...

@editwentyone
Copy link

with this api we could more or less randomize it even https://colornames.org/download/
example: https://colornames.org/search/results/?type=exact&query=plum

@editwentyone
Copy link

a labeling what also help to make it more readable: (no Jar in front, maybe no bold first letter) - what do you think?

  • Apricot
  • Blueberry
  • Cherry
  • Date
  • Elderberry

@dergigi
Copy link
Contributor Author

dergigi commented Aug 11, 2022

We had some more discussions on this in Call 21. Unless someone objects, I feel like we should strive to include this in v0.1.

I will update the docs accordingly, and unless there are volunteers I'm happy to implement this myself.

@dergigi dergigi self-assigned this Aug 11, 2022
@dergigi dergigi added this to the v0.1.0 - Tasty Parity milestone Aug 11, 2022
@dergigi dergigi added this to JAM Aug 11, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Sounds good! I'm not so sure about making the colors random, though. I feel like that might be confusing and make it harder to memorize which Jar is which. After all, the colors should be an additional memory aid, i.e. Jar A should always be orange, Jar B always be blue, etc...

@dergigi
Copy link
Contributor Author

dergigi commented Aug 11, 2022

Agree! No randomness required.

@ghost
Copy link

ghost commented Aug 12, 2022

Would you be able to come up with a nicely looking color scheme @editwentyone?

@editwentyone
Copy link

not yet, are we already fixe with the names?

Apricot
Blueberry
Cherry
Date
Elderberry

or are there other suggestions?

@editwentyone
Copy link

@editwentyone
Copy link

what do you think @dnlggr ? "Date" in darkmode is possibly to red, but I think its ok to start with

@dergigi
Copy link
Contributor Author

dergigi commented Aug 18, 2022

Nice, I like it!

I agree @editwentyone that Date is a bit too red when on black, and Blueberry and Elderberry might also be too close together. I'll see if I can get to implementing this before v0.1 and might play around with the colors a bit. 🎨 🧑‍🎨

@editwentyone
Copy link

I updated the dark mode version again, see here https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=5072%3A61903

image

@dergigi
Copy link
Contributor Author

dergigi commented Aug 18, 2022

Adjusted the colors slightly, made the Date one a bit more brown and the Elderberry one a bit more violet-ish.

Let me know what you think!

image

See #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants