Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: colored jars with names #476

Merged
merged 19 commits into from
Aug 18, 2022
Merged

feat: colored jars with names #476

merged 19 commits into from
Aug 18, 2022

Conversation

dergigi
Copy link
Contributor

@dergigi dergigi commented Aug 18, 2022

Resolves #435

I did the coloring and naming in one go, apologies for the large changeset.

In short:

  • Jar #0 is now Jar A, etc.
  • Short form is used in detail views
  • Long form (full flavor name) is used in main views
  • Colors added to wallet overview

We could definitely go nuts with the details, i.e. add color to the little jar icons where appropriate, etc. I decided to not go nuts in this PR, we can implement this later as a nice-to-have.

The goal of this PR is to get rid of 0/1/2/3/4 to not confuse noobs too much, and switch to A/B/C/D/E.

📸 Screenshots

Screenshot 2022-08-18 at 16-26-13 Jam for JoinMarket

Screenshot 2022-08-18 at 16-26-41 Jam for JoinMarket


👉 More screenshots below the fold 👇

📷🌚 More dark mode screenshots

Screenshot 2022-08-18 at 16 24 04

Screenshot 2022-08-18 at 16-18-02 Jam for JoinMarket

📷🌝 More light mode screenshots

Screenshot 2022-08-18 at 16 27 46 Screenshot 2022-08-18 at 16 27 41 Screenshot 2022-08-18 at 16 27 30 Screenshot 2022-08-18 at 16 27 08

@dergigi dergigi added the UI/UX Issue related to cosmetics, design, or user experience label Aug 18, 2022
@dergigi dergigi self-assigned this Aug 18, 2022
@dergigi dergigi requested a review from editwentyone August 18, 2022 14:39
@theborakompanioni theborakompanioni merged commit 6a050f4 into master Aug 18, 2022
@theborakompanioni theborakompanioni deleted the colored-jars branch August 18, 2022 20:39
@dergigi
Copy link
Contributor Author

dergigi commented Aug 19, 2022

Oh, nice, using first-letter css is way smarter! Thanks! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concept: named jars (orange, strawberry, etc.)
2 participants