small ui improvements and bugfixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when navigating to the reiceve page with a specific account, the qr code has not been loaded. this fix will ensure the account type is an integer and hence the qrcode is loaded as expected.
a value of zero will actually send the entire amount. this is probably not what the user expects. solving this by requiring the value to be greater than zero.
dennisreimann
approved these changes
Jan 1, 2022
0xSaksham
added a commit
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request contains some small ui improvements and bugfixes.
fix:
a value of zero will actually send the entire amount.
this is probably not what the user expects.
solving this by requiring the value to be greater than zero.
when navigating to the receive page with a specific account,
the qr code has not been loaded. this fix will ensure the account
type is an integer and hence the qrcode is loaded as expected.
ui: