Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reporting test durations #205

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix reporting test durations #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/runner/runESLint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ const mkTestResults = ({
start: startTime,
end: endTime,
duration: endTime - startTime,
runtime: endTime - startTime,
Comment on lines 75 to +76
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of these seems silly to me - I'd assume Jest could figure it out on its own... I'll dig into this a bit more tomorrow and attempt to figure out why this would be needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in Jest is jestjs/jest#14473, but that would only fix it for Jest 29 - this regressed in Jest 26

slow: false,
},
skipped: numPassingTests === 0 && numFailingTests === 0,
Expand Down