fix(test-sequencer): correctly figure out test runtime #14473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
commented
Sep 6, 2023
| @@ -219,9 +221,11 @@ export default class TestSequencer { | |||
| if (test != null && !testResult.skipped) { | |||
| const cache = this._getCache(test); | |||
| const perf = testResult.perfStats; | |||
| const testRuntime = | |||
| perf.runtime ?? test.duration ?? perf.end - perf.start; | |||
There was a problem hiding this comment.
fix is falling back to perf.end - perf.start (as it was before #9366), but also checking test.duration seems sensible to me.
SimenB
commented
Sep 6, 2023
| cache[testResult.testFilePath] = [ | ||
| testResult.numFailingTests ? FAIL : SUCCESS, | ||
| perf.runtime || 0, | ||
| testResult.numFailingTests > 0 ? FAIL : SUCCESS, |
There was a problem hiding this comment.
not related to the rest of the changes, but I don't like 0 being falsy as the check 😅
SimenB
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This broke for reporters not reporting the new
runtimeoption in https://github.com/jestjs/jest/pull/9366/files#diff-13b8119e2dc016b1f90c8f3dff4d9783a4ab4513ff65e87b3200a7deb3d07427Brought to my attention via jest-community/jest-runner-eslint#204
I've also done some type and helper tweaks while I was here
Test plan
Tweaked the test to show that the value is calculated correctly.