Fix reporting test durations #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems weird to me Jest has both of these - when would they differ? EDIT: Hmm, seems |
SimenB
reviewed
Sep 3, 2023
Comment on lines
75
to
+76
| duration: endTime - startTime, | ||
| runtime: endTime - startTime, |
There was a problem hiding this comment.
both of these seems silly to me - I'd assume Jest could figure it out on its own... I'll dig into this a bit more tomorrow and attempt to figure out why this would be needed
There was a problem hiding this comment.
Fix in Jest is jestjs/jest#14473, but that would only fix it for Jest 29 - this regressed in Jest 26
|
Thanks for tracking it down and getting this merged so swiftly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204.
Jest appears to have changed the format of
TestResult. What wasperfStats.durationis nowperfStats.runtime:https://github.com/jestjs/jest/blob/edeecfae240bfd54b33f3c9eae156bd157447e5a/packages/jest-test-result/src/types.ts#L90-L122
Adding
runtimeproperty solves the problem.I've left the
durationproperty in place too in case that provides compatibility with older versions of Jest.