Test git plugin upgrade of promoted builds dependency #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tests git client plugin upgrade to require Jenkins 2.426.3 or newer Evaluates two pending pull requests: * jenkinsci/git-client-plugin#1129 * jenkinsci/git-plugin#1581
Installed on over 10k controllers and an optional dependency of the git plugin. Better to test it in the plugin BOM than be surprised when updates cause test failures.
|
Tests failed with git plugin dependency upgrade. Tests failed even worse with addition of promoted builds plugin to the plugin bill of materials. The Job DSL plugin would need to be added to the plugin BOM as well. |
|
Adding the Job DSL plugin allows several of the failing tests to pass but exposes other tests that fail due to the addition of the Job DSL plugin. Failures happen in Test Failures
|
MarkEWaite
deleted the
test-git-plugin-with-newer-promoted-builds-dependency
branch
MarkEWaite
pushed a commit
to MarkEWaite/parameterized-trigger-plugin
that referenced
this pull request
May 6, 2024
892.vd6219fc0a_efb was released 2 years ago. Over 50% of all installations of the promoted builds plugin are already using 892.vd6219fc0a_efb or newer. Those users will see no difference from this change, since they are already using 892.vd6219fc0a_efb. Recent Jenkins versions will display broken icons with older versions of the promoted builds plugin. Fixed in jenkinsci/promoted-builds-plugin#170 as part of 873.v6149db_d64130 https://stats.jenkins.io/pluginversions/promoted-builds.html shows that 892.vd6219fc0a_efb is the second most popular release. It is second only to the most recent release, 945.v597f5c6a_d3fd. A step towards eventually upgrading the promoted-builds optional dependency that is part of the git plugin. Attempts to update that optional dependency have shown consistent failures in the plugin bill of materials. * jenkinsci/bom#3170 * jenkinsci/bom#2809 Bumps [promoted-builds](https://github.com/jenkinsci/promoted-builds-plugin) from 3.11 to 892.vd6219fc0a_efb - [Release notes](https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/892.vd6219fc0a_efb) Also removes unnecessary exclusions
MarkEWaite
added a commit
to MarkEWaite/git-plugin
that referenced
this pull request
May 6, 2024
892.vd6219fc0a_efb was released 2 years ago. Over 50% of all installations of the promoted builds plugin are already using 892.vd6219fc0a_efb or newer. Those users will see no difference from this change, since they are already using 892.vd6219fc0a_efb. Recent Jenkins versions will display broken icons with older versions of the promoted builds plugin. Fixed in jenkinsci/promoted-builds-plugin#170 as part of 873.v6149db_d64130. Upgrading to 892.vd6219fc0a_efb will fix that issue for users. https://stats.jenkins.io/pluginversions//promoted-builds.html shows that 892.vd6219fc0a_efb is the second most popular release. It is second only to the most recent release, 945.v597f5c6a_d3fd. Attempts to update that optional dependency to the most recent release have shown consistent failures in the plugin bill of materials. * jenkinsci/bom#3170 * jenkinsci/bom#2809 This likely needs to be combined with the parameterized trigger plugin upgrade of the same dependency to the same version. Refer to * jenkinsci/parameterized-trigger-plugin#378 Bumps [promoted-builds](https://github.com/jenkinsci/promoted-builds-plugin) from 3.11 to 892.vd6219fc0a_efb - [Release notes](https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/892.vd6219fc0a_efb)
MarkEWaite
added a commit
to jenkinsci/git-plugin
that referenced
this pull request
May 7, 2024
* Require Jenkins 2.426.3 or newer https://stats.jenkins.io/pluginversions/git.html shows that 82% of the 125k installations of the 5.2.1 release (most recent, 6 months old) are already running 2.426.3 or newer. https://www.jenkins.io/security/advisory/2024-01-24/#SECURITY-3314 was published in Jan 2024 and strongly recommends that users upgrade to 2.426.3 or newer. * Test with promoted-builds 940.va_9b_59a_717a_b_1 Removes the dependency on project-inheritance. Previous releases resolved the security issue that was still open in 3.11. * Remove recently introduced trailing white space * Remove dependabot exclusion of promoted builds * Use (optional) promoted builds 945.v597f5c6a_d3fd * Remove diff to master branch * Bump promoted-builds optional dependency to 892.vd6219fc0a_efb 892.vd6219fc0a_efb was released 2 years ago. Over 50% of all installations of the promoted builds plugin are already using 892.vd6219fc0a_efb or newer. Those users will see no difference from this change, since they are already using 892.vd6219fc0a_efb. Recent Jenkins versions will display broken icons with older versions of the promoted builds plugin. Fixed in jenkinsci/promoted-builds-plugin#170 as part of 873.v6149db_d64130. Upgrading to 892.vd6219fc0a_efb will fix that issue for users. https://stats.jenkins.io/pluginversions//promoted-builds.html shows that 892.vd6219fc0a_efb is the second most popular release. It is second only to the most recent release, 945.v597f5c6a_d3fd. Attempts to update that optional dependency to the most recent release have shown consistent failures in the plugin bill of materials. * jenkinsci/bom#3170 * jenkinsci/bom#2809 This likely needs to be combined with the parameterized trigger plugin upgrade of the same dependency to the same version. Refer to * jenkinsci/parameterized-trigger-plugin#378 Bumps [promoted-builds](https://github.com/jenkinsci/promoted-builds-plugin) from 3.11 to 892.vd6219fc0a_efb - [Release notes](https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/892.vd6219fc0a_efb) * Do not check for promoted-builds updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test git plugin upgrade of promoted builds dependency
Previous attempts to upgrade the optional promoted builds dependency in the git plugin caused failures in the plugin bill of materials. Let's try a more recent version of the promoted builds plugin that removes the dependency on the project-inheritance plugin.
Also tests git client plugin upgrade to require Jenkins 2.426.3 or newer
Evaluates two pending pull requests:
Possible thanks to pull request:
project-inheritancepromoted-builds-plugin#272Testing done
Confirmed that
PLUGINS=git,git-client bash local-test.shpassesSubmitter checklist