Fix broken icons in Jenkins 2.333, replace PNGs with SVGs and use modern build status icons instead of balls #170
Conversation
|
Heyo, uh I'm not sure who maintains this plugin at the moment but I noticed that @batmat pushed some maintenance commits, would you mind taking a look at this PR? |
|
Why where the icons removed from core without replacement or aliasing? Icons are part of the API as much as java code and this would appear to be a regression? Is this purely because the plugin was not using (cloudbees-folder I recall also was tripped up as the GREY icon got removed (and then re-added) ) |
Core does overwrite icons in order of GIF -> PNG -> SVG (for Tango) -> ionicon, hence there's a blue arrow on the screenshot I attached, because the promotions plugin does now reference Previously, the promotions plugin read the icon from its path The path does no longer exist, because the GIF and PNG sprites have been removed in favor of the SVG ones. However, if a plugin does use the API of the icon class to place an icon, e.g. The plugins affected by the removal are the ones that didn't use the API in the first place and relied on the icon path itself. I published a blog article at jenkins.io to provide a bit of guidance how to migrate from the usage of icon paths to the appropriate icon class API.
Yeah, but that was down to the icon not being registered in the first place, hence the icon overwrite couldn't apply here. |
jtnord
changed the title
|
Looks like now the I have asked @car-roll to give it a try. I've given him access as a maintainer. |
892.vd6219fc0a_efb was released 2 years ago. Over 50% of all installations of the promoted builds plugin are already using 892.vd6219fc0a_efb or newer. Those users will see no difference from this change, since they are already using 892.vd6219fc0a_efb. Recent Jenkins versions will display broken icons with older versions of the promoted builds plugin. Fixed in jenkinsci/promoted-builds-plugin#170 as part of 873.v6149db_d64130 https://stats.jenkins.io/pluginversions/promoted-builds.html shows that 892.vd6219fc0a_efb is the second most popular release. It is second only to the most recent release, 945.v597f5c6a_d3fd. A step towards eventually upgrading the promoted-builds optional dependency that is part of the git plugin. Attempts to update that optional dependency have shown consistent failures in the plugin bill of materials. * jenkinsci/bom#3170 * jenkinsci/bom#2809 Bumps [promoted-builds](https://github.com/jenkinsci/promoted-builds-plugin) from 3.11 to 892.vd6219fc0a_efb - [Release notes](https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/892.vd6219fc0a_efb) Also removes unnecessary exclusions
892.vd6219fc0a_efb was released 2 years ago. Over 50% of all installations of the promoted builds plugin are already using 892.vd6219fc0a_efb or newer. Those users will see no difference from this change, since they are already using 892.vd6219fc0a_efb. Recent Jenkins versions will display broken icons with older versions of the promoted builds plugin. Fixed in jenkinsci/promoted-builds-plugin#170 as part of 873.v6149db_d64130. Upgrading to 892.vd6219fc0a_efb will fix that issue for users. https://stats.jenkins.io/pluginversions//promoted-builds.html shows that 892.vd6219fc0a_efb is the second most popular release. It is second only to the most recent release, 945.v597f5c6a_d3fd. Attempts to update that optional dependency to the most recent release have shown consistent failures in the plugin bill of materials. * jenkinsci/bom#3170 * jenkinsci/bom#2809 This likely needs to be combined with the parameterized trigger plugin upgrade of the same dependency to the same version. Refer to * jenkinsci/parameterized-trigger-plugin#378 Bumps [promoted-builds](https://github.com/jenkinsci/promoted-builds-plugin) from 3.11 to 892.vd6219fc0a_efb - [Release notes](https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/892.vd6219fc0a_efb)
* Require Jenkins 2.426.3 or newer https://stats.jenkins.io/pluginversions/git.html shows that 82% of the 125k installations of the 5.2.1 release (most recent, 6 months old) are already running 2.426.3 or newer. https://www.jenkins.io/security/advisory/2024-01-24/#SECURITY-3314 was published in Jan 2024 and strongly recommends that users upgrade to 2.426.3 or newer. * Test with promoted-builds 940.va_9b_59a_717a_b_1 Removes the dependency on project-inheritance. Previous releases resolved the security issue that was still open in 3.11. * Remove recently introduced trailing white space * Remove dependabot exclusion of promoted builds * Use (optional) promoted builds 945.v597f5c6a_d3fd * Remove diff to master branch * Bump promoted-builds optional dependency to 892.vd6219fc0a_efb 892.vd6219fc0a_efb was released 2 years ago. Over 50% of all installations of the promoted builds plugin are already using 892.vd6219fc0a_efb or newer. Those users will see no difference from this change, since they are already using 892.vd6219fc0a_efb. Recent Jenkins versions will display broken icons with older versions of the promoted builds plugin. Fixed in jenkinsci/promoted-builds-plugin#170 as part of 873.v6149db_d64130. Upgrading to 892.vd6219fc0a_efb will fix that issue for users. https://stats.jenkins.io/pluginversions//promoted-builds.html shows that 892.vd6219fc0a_efb is the second most popular release. It is second only to the most recent release, 945.v597f5c6a_d3fd. Attempts to update that optional dependency to the most recent release have shown consistent failures in the plugin bill of materials. * jenkinsci/bom#3170 * jenkinsci/bom#2809 This likely needs to be combined with the parameterized trigger plugin upgrade of the same dependency to the same version. Refer to * jenkinsci/parameterized-trigger-plugin#378 Bumps [promoted-builds](https://github.com/jenkinsci/promoted-builds-plugin) from 3.11 to 892.vd6219fc0a_efb - [Release notes](https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/892.vd6219fc0a_efb) * Do not check for promoted-builds updates
Originally, I was going ahead to fix the broken icons that referenced to paths that have been removed from core, e.g. in
but I've taken the opportunity to exchange the GIF and PNG icons with SVGs that were already added and got a rid of the ball colors in favor of the modernized build status: