-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require 2.426.3 as minimum Jenkins version #1129
Conversation
…insci#1099) List more operating systems so that web searches will find the page. Link to the operating system end of life blog post. Correct the name of Amazon Linux name. Add the most important option, upgrade to a supported operating system.
Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 4.76 to 4.77. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.76...plugin-4.77) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Included in parent pom 4.77
Thanks for the pull request @AniketNS . The pull request has some gaps that you can use on your journey of learning about git, GitHub, and pull requests.
If you'd like to use the pull request to learn more about git and about GitHub pull requests, you can resolve the conflict with the destination branch and submit the additional commits that resolve the conflict. Some of the commands that you'll need to use to resolve the conflict include:
If you'd rather close the pull request and submit a new pull request, that is fine as well. |
Yeah I'll do that @MarkEWaite. Thanks for the feedback |
For this specific commit, there is also a very useful data source that some maintainers use to decide when they will upgrade the minimum required Jenkins version. The Jenkins documentation page "Choosing a Jenkins version to build against" provides the guidelines and instructions to help maintainers choose a new Jenkins base version. In addition to those instructions, each plugin has a link to "View detailed version information" on its plugins.jenkins.io page. For the git client, the detailed version information page shows the following information when hovering over various parts of that page:
|
Thanks for the detailed feedback @MarkEWaite and the detailed information about the code.
That's true but, I didn't understand why, even if I create a different branch those older commits are coming in the way. But I didn't see any code from those commits that's why It didn't trigger me.
I was indeed using the Update Jenkins version and that's why I made that change. I would've mentioned that in the PR description.
I read the document, but as a newbie, I didn't understand a thing from Choosing a Jenkins version to build against but looked into detailed version information page and it was kinda interesting and got some nice info about git-client plugin versions, updates and it's downloads. I've somehow removed the conflict. Tell me if there's anything I should change. Thanks. |
That likely means your local copy is out of sync with the upstream repository or is out of sync with your fork of the upstream repository. One simple way to fix that is to rename your local repository to and clone it again. |
Ohh ok @MarkEWaite. I'll look more into git commands. |
Also tests git client plugin upgrade to require Jenkins 2.426.3 or newer Evaluates two pending pull requests: * jenkinsci/git-client-plugin#1129 * jenkinsci/git-plugin#1581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge. Git plugin 5.2.2 was released recently and requires Jenkins 2.426.3 or newer. Next release date of git client plugin is not yet decided, but it makes sense that the next release require Jenkins 2.426.3 or newer.
Require 2.426.3 as minimum Jenkins version
Jenkins 2.426.3 is now one of the recommended versions in the Jenkins documentation. Jenkins 2.426.3 includes an important security fix that should motivate more users to install it or a newer version.
Summary:
The vast majority of users that are installing the most recent release of the git client plugin are already running Jenkins 2.426.3 or newer.
Checklist
Types of changes
What types of changes does your code introduce?