[iOS] Admin Dashboard - User Access Tags #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…Swiftfin into jpkribs/adminDashboardBlockTags
|
The largest design change I made was to remove the label for what kind of tag it is. Instead, once |
LePips
approved these changes
Jan 3, 2025
ddrccw
added a commit
to ddrccw/Swiftfin
that referenced
this pull request
Jan 26, 2025
* upstream/main: (392 commits) [tvOS] Add pin prompt to sign-in screen (jellyfin#1383) [iOS] Admin Dashboard - User Access Tags (jellyfin#1377) [Meta] 2025 Disclaimer (jellyfin#1381) [tvOS] Delete User from User Selection Screen (jellyfin#1359) [iOS] Media Item Menu - Identify Media Item (jellyfin#1369) [iOS] Admin Dashboard - User Profiles (jellyfin#1328) [iOS] Select all Users When Editing (jellyfin#1373) [Meta] Automatic String Organization (jellyfin#1372) [iOS & tvOS] Unused Localization Cleanup (jellyfin#1362) [tvOS] SelectServerView Change to Menu (jellyfin#1363) [tvOS] Update ConnectToServerView & UserSignInView (jellyfin#1365) Trim Fastlane Options (jellyfin#1367) Update Fastlane Runner (jellyfin#1366) [iOS & tvOS] Localize Existing Strings (jellyfin#1361) [iOS] Admin Dashboard - User Access Schedules (jellyfin#1358) [iOS] Admin Dashboard - Parental Ratings (jellyfin#1353) [iOS & tvOS] Error Cleanup (jellyfin#1357) update (jellyfin#1356) Fix possible duplicate ids (jellyfin#1354) [tvOS] Media Item Menu - Refresh / Delete Items (jellyfin#1348) ... Signed-off-by: ddrccw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts the works for managing Access Tags. On 10.8, we only have the ability to set
BlockedTagswhich removes the ability for a user to see media with that tag. In 10.10, there will beAllowedTagswhich block ALL media for that user unless the media has one of theAllowedTags.The view I am using should work for both but I have the
AllowedTagslogic commented out for us to enable when it's available. I reused the Trie from the Tags/Genres/People/Studios editing: #1336. This is almost a copy/paste ofEditItemElementViewbut I am turning all of the tags into[String:Bool]where I am tracking both the tag and whether it allows or blocks access. This allows us to do all of this on a single view instead of breaking it out. Since the object we are editing are just tags, having a secondaryBooldoesn't add much clutter.Since this item is incomplete before 10.10, I'm fine sitting on this one for a bit but the change to get this working for 10.10 should be very easy and this should be feature complete for 10.8.
Screenshots
New Button
Empty View
New Entry
LearnMore
Tag Searching
Tag Validation
Populated View