Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Select all Users When Editing #1373

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

chickdan
Copy link
Contributor

@chickdan chickdan commented Dec 21, 2024

Simple change, adds a button when editing users to select all users for faster management and moves the buttons to the toolbars.

@chickdan chickdan changed the title [iOS] Add button to select all users when editing [iOS] Select all Users When Editing Dec 21, 2024
@LePips
Copy link
Member

LePips commented Dec 21, 2024

Over the development of the dashboard we've established a pattern on iOS where the Select/Remove All, Cancel, and even Delete are in the toolbars instead. We should be moving to that here too.

@chickdan
Copy link
Contributor Author

chickdan commented Dec 21, 2024

Over the development of the dashboard we've established a pattern on iOS where the Select/Remove All, Cancel, and even Delete are in the toolbars instead. We should be moving to that here too.

Gotcha, I can make that change.

@LePips
Copy link
Member

LePips commented Dec 23, 2024

I just added Remove All as well.

@chickdan
Copy link
Contributor Author

Whoops, sorry for leaving the old button behind.

@LePips LePips merged commit 2f13093 into jellyfin:main Dec 23, 2024
4 checks passed
@chickdan chickdan deleted the ios_select_all_users branch December 23, 2024 18:44
ddrccw added a commit to ddrccw/Swiftfin that referenced this pull request Jan 26, 2025
* upstream/main: (392 commits)
  [tvOS] Add pin prompt to sign-in screen (jellyfin#1383)
  [iOS] Admin Dashboard - User Access Tags (jellyfin#1377)
  [Meta] 2025 Disclaimer (jellyfin#1381)
  [tvOS] Delete User from User Selection Screen (jellyfin#1359)
  [iOS] Media Item Menu - Identify Media Item (jellyfin#1369)
  [iOS] Admin Dashboard - User Profiles (jellyfin#1328)
  [iOS] Select all Users When Editing (jellyfin#1373)
  [Meta] Automatic String Organization (jellyfin#1372)
  [iOS & tvOS] Unused Localization Cleanup (jellyfin#1362)
  [tvOS] SelectServerView Change to Menu (jellyfin#1363)
  [tvOS] Update ConnectToServerView & UserSignInView (jellyfin#1365)
  Trim Fastlane Options (jellyfin#1367)
  Update Fastlane Runner (jellyfin#1366)
  [iOS & tvOS] Localize Existing Strings (jellyfin#1361)
  [iOS] Admin Dashboard - User Access Schedules (jellyfin#1358)
  [iOS] Admin Dashboard - Parental Ratings (jellyfin#1353)
  [iOS & tvOS] Error Cleanup (jellyfin#1357)
  update (jellyfin#1356)
  Fix possible duplicate ids (jellyfin#1354)
  [tvOS] Media Item Menu - Refresh / Delete Items (jellyfin#1348)
  ...

Signed-off-by: ddrccw <[email protected]>
@JPKribs JPKribs added the enhancement New feature or request label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants