[tvOS] Media Item Menu - Refresh / Delete Items

[JPKribs]

Summary

This should be the full extent of tvOS item management. I can't imagine that anyone want to manually write metadata or replace images from their TV. Instead, this should allow refreshing metadata if data is missing or some information is wrong. Additionally, if enabled, this should allow for deleting items which was a popular ask on the Android TV side: jellyfin/jellyfin-androidtv#2368

This should almost 1 to 1 mirror iOS with some small differences:

1. Since this is on the ActionHStack, I don't have router access to dismiss the coordinator on item Deletion. The result is the user needs to manually go back.
2. iOS has a loading ProgressView() on the Refresh Metadata button. Since tvOS's button is hidden behind the menu, I removed the loading circle since it was giving some weird flashing (at least on the emulator)

Screenshots

Buttons - No Access vs Access

Menu Buttons

Refresh Options

Delete Warning

[LePips]

Since this is on the ActionHStack, I don't have router access to dismiss the coordinator on item Deletion. The result is the user needs to manually go back.

That isn't necessarily true as routers are retrieved via EnvironmentObject. For example, the following works as all items are presented with an ItemCoordinator. I did test this, however I ran into the same issue as #1090 (comment), where I had to delete the .receive(on: RunLoop.main) in DeleteItemViewModel.events. I'm still unsure why this is an issue. I also did not test iOS.

@EnvironmentObject
private var router: ItemCoordinator.Router

//...

.onReceive(deleteViewModel.events) { event in
    switch event {
    case let .error(eventError):
        error = eventError
        isPresentingEventAlert = true
    case .deleted:
        router.dismissCoordinator()
    }
}

[JPKribs]

That isn't necessarily true as routers are retrieved via EnvironmentObject.

Ah! My bad, yes this worked. I did have to delete the .receive(on: RunLoop.main) in DeleteItemViewModel.events While I was in there, I cleaned up some of the states / backgroundStates since this really only does item deletion and I over-engineered some non-existent scenarios when I made this.

I validated that this does work! Additionally, with the new Notifications, I no longer need the onNotification to refresh the data source. Instead, it's appropriately handled by the ViewModel which is perfect.

IMO, this is all ready to go! Only item that may need an adjustment is:

iOS has a loading ProgressView() on the Refresh Metadata button. Since tvOS's button is hidden behind the menu, I removed the loading circle since it was giving some weird flashing (at least on the emulator)

I going over some of what I've done, there are like 3 differing formats for errors. Just varying versions of the same thing that are all roughly the same but have some weird interactions. The issue I ran into working on this is one of error that I had on iOS didn't have a way to dismiss it. I wanted to just knock that out since copying and pasting clearing isn't working for me lol.

import SwiftUI

struct ErrorMessageModifier: ViewModifier {

    @Binding
    var error: Error?

    let dismissActions: (() -> Void)?

    // MARK: - Body

    func body(content: Content) -> some View {
        content
            .alert(
                L10n.error.text,
                isPresented: .constant(error != nil),
                presenting: error
            ) { _ in
                Button(L10n.dismiss, role: .cancel) {
                    error = nil
                    dismissActions?()
                }
            } message: { error in
                Text(error.localizedDescription)
            }
    }
}

So, we should just be able to call .errorMessage(error: error) and have a consistent error message across the board. Let me know if you think this is a good call! I just made it present on error != nil and dismiss resets the error back to nil. There is an optional dismiss action if we need anything else.

Looks like this:

[LePips]

Looks great!