Handle reverse move and models.permalink removal #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 97.63% 97.67% +0.03%
==========================================
Files 15 15
Lines 593 601 +8
Branches 73 73
==========================================
+ Hits 579 587 +8
Misses 7 7
Partials 7 7
Continue to review full report at Codecov.
|
rossmechanic
requested changes
Dec 6, 2017
| @@ -204,14 +208,12 @@ def get_extra_fields(self, model, fields): | |||
|
|
|||
| user_model = getattr(settings, 'AUTH_USER_MODEL', 'auth.User') | |||
|
|
|||
| @models.permalink | |||
| def revert_url(self): | |||
There was a problem hiding this comment.
Are there any tests in the test suite that are testing this function? Couldn't find any. Want to add one and include it with the PR?
There was a problem hiding this comment.
@rossmechanic I added a simple test of the reverse_url() output; there was an existing test that called it, but this looks like the first one to sanity check the output.
jmbowman
force-pushed
the
reverse_and_permalink
branch
from
e4751e0 to
d335b29
Compare
|
Fixed in #363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle two of the changes in recent Django versions mentioned in #291 -
reverse()fromdjango.core.urlresoverstodjango.urlsmodels.permalinkCompatibility with all currently supported Django versions should be maintained. I realize that #320 also has a fix for the first point, but it seems to have gotten bogged down in figuring out how to handle some of the other changes; it might make sense to just merge these simple fixes first.