Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Django 1.9 leftovers #363

Merged
merged 5 commits into from
Apr 4, 2018

Conversation

wizpig64
Copy link
Contributor

@wizpig64 wizpig64 commented Apr 3, 2018

Follow up to #362

  • Removed a pointless MiddlewareMixin alias in simple_history/middleware.py that was part of an old compatibility shim.
  • Tests now use the MIDDLEWARE setting rather than MIDDLEWARE_CLASSES. This isn't required until Django 2.0, but now that 1.9 is dropped I see no reason not to switch over now.
  • Import reverse() from django.urls rather than deprecated django.core.urlresolvers module.
  • Removed usage of django's deprecated @models.permalink decorator. (Deprecated in 1.11, but the fix might as well be done now.)

Thanks :)

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #363 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   96.83%   96.83%   +<.01%     
==========================================
  Files          14       14              
  Lines         568      569       +1     
  Branches       70       70              
==========================================
+ Hits          550      551       +1     
  Misses         13       13              
  Partials        5        5
Impacted Files Coverage Δ
simple_history/models.py 96.35% <100%> (+0.01%) ⬆️
simple_history/admin.py 97.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96345c...fe2d478. Read the comment docs.

@rossmechanic
Copy link
Collaborator

lgtm. Thanks for the changes @wizpig64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants