Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warnings from Django 1.11 #291

Closed
merwok opened this issue Jun 16, 2017 · 4 comments
Closed

Address warnings from Django 1.11 #291

merwok opened this issue Jun 16, 2017 · 4 comments

Comments

@merwok
Copy link

merwok commented Jun 16, 2017

These are the warnings when running with Django 1.11:

  • Importing from django.core.urlresolvers is deprecated in favor of django.urls.
  • Usage of ForeignObjectRel.to attribute has been deprecated. Use the model attribute instead.
  • Usage of field.rel has been deprecated. Use field.remote_field instead.
  • django.utils.translate.string_concat() is deprecated in favor of django.utils.text.format_lazy().
  • permalink() is deprecated in favor of calling django.urls.reverse() in the decorated method.

I could see how simple_history handles compat (util module or try/excepts) and make a PR, but not until a few weeks.

@seocam
Copy link

seocam commented Jul 7, 2017

Also

  • Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.

@merwok
Copy link
Author

merwok commented Nov 7, 2017

PR #320 addresses some of the issues.

@rossmechanic
Copy link
Collaborator

Handled since we upgraded to 2.0

@merwok
Copy link
Author

merwok commented Apr 6, 2018

Great news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants