Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: create new thread with last chosen model #4524

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jan 26, 2025

Describe Your Changes

This pull request includes a small but significant change to the useCreateNewThread hook in the web/hooks/useCreateNewThread.ts file. The change introduces the use of a selectedModel state value to prioritize the model selection process when creating a new thread.

Key change:

  • web/hooks/useCreateNewThread.ts: Added selectedModel from the selectedModelAtom and updated the defaultModel assignment to prioritize selectedModel over recommendedModel when no specific model is provided.

Fixes Issues

Screen.Recording.2025-01-26.at.22.26.18.mov

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: enhancement Improves a current feature label Jan 26, 2025
@urmauur urmauur added this to the v0.5.15 milestone Jan 26, 2025
@urmauur urmauur requested a review from louis-menlo January 26, 2025 15:35
@urmauur urmauur self-assigned this Jan 26, 2025
Copy link
Contributor

Barecheck - Code coverage report

Total: 67.96%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
web/hooks/useCreateNewThread.ts139-140, 142-143, 150-151, 162, 171, 208, 212, 214

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 6288384 into dev Jan 27, 2025
19 checks passed
@urmauur urmauur deleted the enhancement/last-selected-model branch January 27, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Jan should remember and default to user's last chosen model
2 participants