Skip to content

Commit

Permalink
enhancement: create new thread with last chosen model (#4524)
Browse files Browse the repository at this point in the history
* enhancement: create new thread with last chosen model

* chore: resolve setting undefined
  • Loading branch information
urmauur authored Jan 27, 2025
1 parent 7f6c8aa commit 6288384
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions web/hooks/useCreateNewThread.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,13 @@ export const useCreateNewThread = () => {

const { recommendedModel } = useRecommendedModel()

const selectedModel = useAtomValue(selectedModelAtom)

const requestCreateNewThread = async (
assistant: (ThreadAssistantInfo & { id: string; name: string }) | Assistant,
model?: Model | undefined
) => {
const defaultModel = model || recommendedModel
const defaultModel = model || selectedModel || recommendedModel

if (!model) {
// if we have model, which means user wants to create new thread from Model hub. Allow them.
Expand All @@ -82,23 +84,23 @@ export const useCreateNewThread = () => {
// Default context length is 8192
const defaultContextLength = Math.min(
8192,
defaultModel?.settings.ctx_len ?? 8192
defaultModel?.settings?.ctx_len ?? 8192
)

const overriddenSettings = {
ctx_len: defaultModel?.settings.ctx_len
? Math.min(8192, defaultModel.settings.ctx_len)
ctx_len: defaultModel?.settings?.ctx_len
? Math.min(8192, defaultModel?.settings?.ctx_len)
: undefined,
}

// Use ctx length by default
const overriddenParameters = {
max_tokens: defaultContextLength
? Math.min(
defaultModel?.parameters.max_tokens ?? 8192,
defaultModel?.parameters?.max_tokens ?? 8192,
defaultContextLength
)
: defaultModel?.parameters.max_tokens,
: defaultModel?.parameters?.max_tokens,
}

const createdAt = Date.now()
Expand Down

0 comments on commit 6288384

Please sign in to comment.