enhancement: create new thread with last chosen model

web/hooks/useCreateNewThread.ts

@@ -51,11 +51,13 @@
 
   const { recommendedModel } = useRecommendedModel()
 
+  const selectedModel = useAtomValue(selectedModelAtom)
+
   const requestCreateNewThread = async (
     assistant: (ThreadAssistantInfo & { id: string; name: string }) | Assistant,
     model?: Model | undefined
   ) => {
-    const defaultModel = model || recommendedModel
+    const defaultModel = model || selectedModel || recommendedModel
 
     if (!model) {
       // if we have model, which means user wants to create new thread from Model hub. Allow them.
@@ -82,23 +84,23 @@
     // Default context length is 8192
     const defaultContextLength = Math.min(
       8192,
-      defaultModel?.settings.ctx_len ?? 8192
+      defaultModel?.settings?.ctx_len ?? 8192
     )
 
     const overriddenSettings = {
-      ctx_len: defaultModel?.settings.ctx_len
-        ? Math.min(8192, defaultModel.settings.ctx_len)
+      ctx_len: defaultModel?.settings?.ctx_len
+        ? Math.min(8192, defaultModel?.settings?.ctx_len)
         : undefined,
     }
 
     // Use ctx length by default
     const overriddenParameters = {
       max_tokens: defaultContextLength
         ? Math.min(
-            defaultModel?.parameters.max_tokens ?? 8192,
+            defaultModel?.parameters?.max_tokens ?? 8192,
             defaultContextLength
           )
-        : defaultModel?.parameters.max_tokens,
+        : defaultModel?.parameters?.max_tokens,
     }
 
     const createdAt = Date.now()
@@ -134,19 +136,19 @@
     // add the new thread on top of the thread list to the state
     try {
       const createdThread = await persistNewThread(thread, assistantInfo)
       if (!createdThread) throw 'Thread created failed.'
       createNewThread(createdThread)
 
       setSelectedModel(defaultModel)
       setThreadModelParams(createdThread.id, {
         ...defaultModel?.settings,
         ...defaultModel?.parameters,
         ...overriddenSettings,
       })
 
       // Delete the file upload state
       setFileUpload(undefined)
       setActiveThread(createdThread)
     } catch (ex) {
       return toaster({
         title: 'Thread created failed.',
@@ -157,7 +159,7 @@
   }
 
   const updateThreadExtension = (thread: Thread) => {
     return extensionManager
       .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
       ?.modifyThread(thread)
   }
@@ -166,7 +168,7 @@
     threadId: string,
     assistant: ThreadAssistantInfo
   ) => {
     return extensionManager
       .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
       ?.modifyThreadAssistant(threadId, assistant)
   }
@@ -203,13 +205,13 @@
       .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
       ?.createThread(thread)
       .then(async (thread) => {
         await extensionManager
           .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
           ?.createThreadAssistant(thread.id, assistantInfo)
           .catch(console.error)
         return thread
       })
       .catch(() => undefined)
   }
 
   return {