Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct model_id in chat #1379

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: correct model_id in chat #1379

merged 3 commits into from
Oct 1, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 1, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

  • Add /models/start and /models/stop endpoint
  • Fallback to cortex.llamacpp if engine is not in request body
  • Use model_handle for model chat id

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 1, 2024 08:40
namchuai
namchuai approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 58ec4f9 into dev Oct 1, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/chat branch October 1, 2024 08:48
@gabrielle-ong gabrielle-ong mentioned this pull request Oct 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: No engine field in request body
2 participants
@vansangpfiev @namchuai