Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: cortex ps and Process Status #1187

Closed
2 tasks done
dan-menlo opened this issue Sep 11, 2024 · 5 comments · Fixed by #1345 or #1363
Closed
2 tasks done

epic: cortex ps and Process Status #1187

dan-menlo opened this issue Sep 11, 2024 · 5 comments · Fixed by #1345 or #1363
Assignees
Labels
type: epic A major feature or initiative
Milestone

Comments

@dan-menlo
Copy link
Contributor

dan-menlo commented Sep 11, 2024

Goal

  • cortex ps lists running models and free/used memory
  • We should ideally be able to show VRAM and RAM use (free vs. total)

Key Questions

  • How do we do this in a stateless manner? (or persist a *.lock to Cortex data folder?)

Linked PRs

DX

cortex start

  • should stdout a link for api playground
  • should correctly handle if port is occupied
20240919 09:30:08.293674 UTC 3351741 INFO  Host: 127.0.0.1 Port: 3928
 - main.cc:32
Server started

Current logs a bit confusing

cortex stop

cortex ps

  • if no active processes, should return a msg to that effect
@dan-menlo dan-menlo added this to Menlo Sep 11, 2024
@dan-menlo dan-menlo converted this from a draft issue Sep 11, 2024
@dan-menlo dan-menlo added the type: epic A major feature or initiative label Sep 11, 2024
@dan-menlo dan-menlo changed the title epic: Cortex Memory Management epic: cortex ps and System Monitor Sep 11, 2024
@dan-menlo dan-menlo changed the title epic: cortex ps and System Monitor epic: cortex ps and Memory Monitor Sep 11, 2024
@dan-menlo dan-menlo changed the title epic: cortex ps and Memory Monitor epic: cortex ps and Process Status Sep 11, 2024
@namchuai namchuai mentioned this issue Sep 26, 2024
3 tasks
@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Sep 30, 2024

@vansangpfiev @namchuai
v124, cortex ps on Windows seems broken
VM: test-windows-app-1-rdp
Image

Works well on Mac and Ubuntu

@vansangpfiev
Copy link
Contributor

vansangpfiev commented Oct 1, 2024

This is not cortex ps command issue.
The root cause is the SIGINT signal (Ctrl + C) terminated the child process (server process).
It works well when we use exit() to exit chat.
Let me try to handle the SIGINT signal in this case.

@vansangpfiev
Copy link
Contributor

@gabrielle-ong Please update cortex.llamacpp engine to latest (v0.1.34) to use the cortex ps command

cortex engines install cortex.llamacpp

@freelerobot
Copy link
Contributor

What attributes are we showing when there are models running?

For reference this is docker:
image

@gabrielle-ong
Copy link
Contributor

CLI UX request: cortex ps should show model alias

  • since that is expected for cortex models stop commands
    Image

Models list
Image

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 3, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: epic A major feature or initiative
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants