Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore SIGINT for server #1371

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: ignore SIGINT for server #1371

merged 3 commits into from
Oct 1, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 1, 2024 •
edited
Loading

Describe Your Changes

cortex chat is working on interactive mode. If we send a SIGINT, the server will be terminated.
We should ignore SIGINT for server.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev changed the title fix: ignore sigint server fix: ignore SIGINT for server Oct 1, 2024
@vansangpfiev vansangpfiev marked this pull request as ready for review October 1, 2024 03:33
@vansangpfiev vansangpfiev merged commit 5c2cae1 into dev Oct 1, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/ignore-sigint-server branch October 1, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai