Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: No engine field in request body #1372

Closed
louis-menlo opened this issue Oct 1, 2024 · 3 comments · Fixed by #1379
Closed

bug: No engine field in request body #1372

louis-menlo opened this issue Oct 1, 2024 · 3 comments · Fixed by #1379
Assignees

Comments

@louis-menlo
Copy link
Contributor

louis-menlo commented Oct 1, 2024

Problem Statement

I'm sending a chat/completions request to the cortex.cpp endpoints, setting up my daily use tools. The request is fully OpenAI compatible. I always receive an error response similar to this:

{
    "message": "No engine field in request body"
}

Feature Idea

Since the cortex.cpp manages to retrieve model information, it should select the engine accordingly. This eliminates the need for an extra engine field in the request, ensuring that 100% OpenAI-compatible products can utilize the endpoint.

@louis-menlo
Copy link
Contributor Author

It always returns an empty response, regardless of how I modify the request body.

@github-project-automation github-project-automation bot moved this to Investigating in Menlo Oct 3, 2024
@vansangpfiev vansangpfiev moved this from Investigating to Review + QA in Menlo Oct 3, 2024
@gabrielle-ong
Copy link
Contributor

@louis-jan can I verify this PR fixes this issue? cc @vansangpfiev

@louis-menlo
Copy link
Contributor Author

Hi @gabrielle-ong, I tested the latest version, and it works now.

97727

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants