-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E test to detect upgrade issues from latest stable Jaeger Operator version #1925
Add E2E test to detect upgrade issues from latest stable Jaeger Operator version #1925
Conversation
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1925 +/- ##
=======================================
Coverage 88.24% 88.24%
=======================================
Files 100 100
Lines 6387 6387
=======================================
Hits 5636 5636
Misses 553 553
Partials 198 198 Continue to review full report at Codecov.
|
Signed-off-by: Israel Blancas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the test has been broken for a while.
@frzifus the test is broken until Jaeger Operator release 1.35 is done |
ahh, got it - thanks :) |
Signed-off-by: Israel Blancas <[email protected]>
…er-operator into add-upgrade-from-previous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, only one question :)
tests/e2e/upgrade/render.sh
Outdated
if [ $IS_OPENSHIFT = true ]; then | ||
skip_test "upgrade-from-latest" "Test not supported in OpenShift" | ||
else | ||
start_test "upgrade-from-latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn it upgrade to latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because you are upgrading from the latest release. The Jaeger Operator we'll test is not released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make then sense to name it *latest-release
?
tests/e2e/upgrade/upgrade-from-latest/install-current-operator.yaml.template
Outdated
Show resolved
Hide resolved
Signed-off-by: Israel Blancas <[email protected]>
…er-operator into add-upgrade-from-previous
Which problem is this PR solving?
Short description of the changes
Blocked by #1924
Closes #1964