Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test to detect upgrade issues from latest stable Jaeger Operator version #1925

Merged
merged 33 commits into from
Jun 28, 2022

Conversation

iblancasa
Copy link
Collaborator

@iblancasa iblancasa commented May 31, 2022

Which problem is this PR solving?

Short description of the changes

  • Add an E2E test which installs the latest stable Jaeger Operator version and tries to upgrade to the one built from the source code

Blocked by #1924

Closes #1964

@iblancasa iblancasa marked this pull request as draft May 31, 2022 12:31
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1925 (3eaf515) into main (7ae5b46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1925   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files         100      100           
  Lines        6387     6387           
=======================================
  Hits         5636     5636           
  Misses        553      553           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae5b46...3eaf515. Read the comment docs.

@iblancasa iblancasa marked this pull request as ready for review June 1, 2022 10:12
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the test has been broken for a while.

@iblancasa
Copy link
Collaborator Author

@frzifus the test is broken until Jaeger Operator release 1.35 is done

@frzifus
Copy link
Member

frzifus commented Jun 16, 2022

ahh, got it - thanks :)

@iblancasa iblancasa marked this pull request as draft June 21, 2022 19:47
@iblancasa iblancasa marked this pull request as ready for review June 27, 2022 11:42
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, only one question :)

if [ $IS_OPENSHIFT = true ]; then
skip_test "upgrade-from-latest" "Test not supported in OpenShift"
else
start_test "upgrade-from-latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn it upgrade to latest?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because you are upgrading from the latest release. The Jaeger Operator we'll test is not released yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make then sense to name it *latest-release?

@frzifus frzifus enabled auto-merge (squash) June 28, 2022 15:51
@frzifus frzifus merged commit fd5f2da into jaegertracing:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger Operator version from upstream image is not set
3 participants