Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger Operator version is not set properly in the container image #1923

Closed
iblancasa opened this issue May 31, 2022 · 0 comments · Fixed by #1924
Closed

Jaeger Operator version is not set properly in the container image #1923

iblancasa opened this issue May 31, 2022 · 0 comments · Fixed by #1924
Labels
bug Something isn't working

Comments

@iblancasa
Copy link
Collaborator

Describe the bug
Jaeger Operator version is not correct in Docker image.

To Reproduce
Steps to reproduce the behavior in the Docker image:

  1. Build the image make docker
  2. Run the version command:
docker run -i quay.io/iblancas/jaeger-operator:1.34.1-11-g5044aa9c version
{"jaeger-operator":"","build-date":"2022-05-31T10:41:53Z","jaeger-version":"1.34.1","go-version":"go1.17.10"}

Expected behavior
The version must be shown in the jaeger-operator field.
@iblancasa iblancasa added the bug Something isn't working label May 31, 2022
iblancasa pushed a commit to iblancasa/jaeger-operator that referenced this issue May 31, 2022
Fix version in Docker container. Closes jaegertracing#1923
08c35b9 
Signed-off-by: Israel Blancas <[email protected]>
@iblancasa iblancasa mentioned this issue May 31, 2022
Merged
rubenvp8510 added a commit that referenced this issue May 31, 2022
@rubenvp8510
Fix version in Docker container. Closes #1923 (#1924)
63d101d 
Signed-off-by: Israel Blancas <[email protected]>

Co-authored-by: Ruben Vargas <[email protected]>
@iblancasa iblancasa mentioned this issue Jun 27, 2022
Closed
frzifus added a commit that referenced this issue Jun 28, 2022
@rubenvp8510 @frzifus
Add E2E test to detect upgrade issues from latest stable Jaeger Opera…
fd5f2da 
…tor version (#1925)

* Add upgrade-from-latest-test

Signed-off-by: Israel Blancas <[email protected]>

* Fix version in Docker container. Closes #1923

Signed-off-by: Israel Blancas <[email protected]>

* Add a E2E test to avoid upgrade issues

Signed-off-by: Israel Blancas <[email protected]>

* Fix getting the latest release

Signed-off-by: Israel Blancas <[email protected]>

* Fix YQ location

Signed-off-by: Israel Blancas <[email protected]>

* Fix image version

Signed-off-by: Israel Blancas <[email protected]>

* Rename test

Signed-off-by: Israel Blancas <[email protected]>

Co-authored-by: Ruben Vargas <[email protected]>
Co-authored-by: Ben B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix version in Docker container. iblancasa/jaeger-operator
1 participant
@iblancasa