Fix metrics selectors #1742
Merged
Fix metrics selectors #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
force-pushed
the
re-enable-metrics
branch
from
ed51cec to
47ea0ca
Compare
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
re-enable-metrics
branch
from
47ea0ca to
e70ac84
Compare
Codecov Report
@@ Coverage Diff @@
## main #1742 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 100 100
Lines 6018 6018
=======================================
Hits 5278 5278
Misses 563 563
Partials 177 177 Continue to review full report at Codecov.
|
rubenvp8510
force-pushed
the
re-enable-metrics
branch
from
11474c6 to
e70ac84
Compare
|
@pavolloffay Please review |
Signed-off-by: Ruben Vargas <[email protected]>
pavolloffay
reviewed
Feb 21, 2022
tests/templates/kuttl-test.yaml
Outdated
| @@ -3,7 +3,7 @@ kind: TestSuite | |||
| crdDir: ../../_build/crds/ | |||
| artifactsDir: ../../_build/artifacts/ | |||
| commands: | |||
| - script: cd ../../.. && make cert-manager | |||
| - script: cd ../../.. && make cert-manager && make deploy-prometheus-operator | |||
There was a problem hiding this comment.
nit: make cert-manager deploy-prometheus-operator
Signed-off-by: Ruben Vargas <[email protected]>
pavolloffay
approved these changes
Mar 8, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas [email protected]
This PR reverts some changes made in #1650 , as we agreed we are going to generate the Prometheus resources but won't publish it on OperatorHub as part of the release to not force users to install Prometheus Operator