Skip to content

Commit

Permalink
Fix metrics selectors (#1742)
Browse files Browse the repository at this point in the history
* Enable metrics

Signed-off-by: Ruben Vargas <[email protected]>

* Fix tests

Signed-off-by: Ruben Vargas <[email protected]>

* Disable prometheus resources creation

Signed-off-by: Ruben Vargas <[email protected]>
  • Loading branch information
rubenvp8510 authored Mar 23, 2022
1 parent e78ca97 commit 306403c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ bundle-build: ## Build the bundle image.

.PHONY: bundle-push
bundle-push: ## Push the bundle image.
$(MAKE) docker-push IMG=$(BUNDLE_IMG)
docker push $(BUNDLE_IMG)

.PHONY: opm
OPM = ./bin/opm
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/jaeger-operator-metrics_v1_service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: Service
metadata:
creationTimestamp: null
labels:
control-plane: jaeger-operator
app.kubernetes.io/component: metrics
name: jaeger-operator
name: jaeger-operator-metrics
spec:
Expand Down
3 changes: 2 additions & 1 deletion config/prometheus/monitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
labels:
control-plane: controller-manager
name: jaeger-operator
name: jaeger-operator-metrics-monitor
spec:
endpoints:
Expand All @@ -19,3 +19,4 @@ spec:
selector:
matchLabels:
name: jaeger-operator
app.kubernetes.io/component: metrics
3 changes: 2 additions & 1 deletion config/rbac/auth_proxy_service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ apiVersion: v1
kind: Service
metadata:
labels:
control-plane: jaeger-operator
name: jaeger-operator
app.kubernetes.io/component: metrics
name: jaeger-operator-metrics
spec:
ports:
Expand Down

0 comments on commit 306403c

Please sign in to comment.