Disable metrics on generated manifest #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
disbale-metrics-default
branch
from
94ae9b5 to
bcb7b68
Compare
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 98 98
Lines 5962 5962
=======================================
Hits 5228 5228
Misses 557 557
Partials 177 177 Continue to review full report at Codecov.
|
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas [email protected]
I had to disable metrics by default because if not the users trying to install the operator will be forced to install prometheus operator.