ff #1
Merged
ff #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix order of overflow items * Add tests
* Add minimum visible items prop * Reset state * Add tests
* Bump unpkg example to 3.0.0 * Update getting-started.md
- @blueprintjs/[email protected]
* remove IHTMLOptionProps, we already have IOptionProps * fix a usage * RadioGroup supports optional label
…2699) * add Example forceUpdate? prop to disable that behavior * deconstruct forceUpdate, fix initial render when false * Example defaultProps
* embed SVG images in Checkbox CSS for pseudo-states. this brings it back to CSS-only so we can rely on pseudo-states! core take a dev dep on a library that enables this, and runs it thru svgo! * remove `<Icon>` indicator from Control * remove checked state from Checkbox * remove font icon support, add background-image layer instead of ::before * DRY mixin * bring back the ::before for :active state * lint
* add alignIndicator + large options to controls examples * add inline switch
* control indicator is inline element, does not rely on line-height * checked-control mixin to share :checked styles with :indeterminate * rename mixins * add disabled switch to xample * move some blocks around
* bring back the padding and use negative margin to offset indicator * fix large+align-right margin
* Basic ::before styles at the top * Indicator uses 1em for size Adjust font-size in large, everything recomputes! Refactor all controls to leverage this (Switch needs a little more work) * Radio indicator::before uses radial-gradient one property replaces six! * Switch indicator-colors() mixin for legibility Bring Switch large & dark variants inside its block * Remove unused Switch variables * move large modifier up to general section * lint * opacity for disabled radio
* common suite of tests for select components * add Omnibar tests! * initial isOpen state respects popoverProps * fix common tests. revert this commit to bring back controlled tests. * Omnibar disable usePortal in tests * comments
* Add ResizeObserver to force popper to rerender when content resizes * Rework observer/resize implmentation, as was only working on intial render * fix typo in comment * Fixing popperUpdater type definition * Align with code style guides * Clean up implementation as per review * Fixing lint error * Only initialise observer once, disconnect to clear observations * Reword comment * Use safeInvoke to avoid type coercion * follow convention when checking if ref exists
* ensure a valid enabled item is selected initially * fix tests
…#2729) * webpack: put assets in assets/ directory, preserve original filename * include hash as query param
* Ensure that button renders text prop if defined * test text is not empty string, preventing regression of 540b88b * Also check children is valid * Add assertion to test text prop
* Give border radius to :only-child of ControlGroup * Adding comment to trigger build
* Added panel stack * First test integrated * Tests added * Transitions adjusted * Updated readme * Made lower case * Dark theme added * Linting fixed * Review items fixed, transitions reverted * Removed extra panelClassName * _panel-stack.scss * minor docs * updated tests * Tests adjusted and fixed * [PanelStack] refactors & fix transitions (#2717) * fix the transitions! * example refactor: move stack to options bar * lint example * refactor header styles to use fewer classes * Classes.PANEL_STACK * fix tests * style fixes, simpler transition * no stack limit * back button nowrap * Adjusted transition to include opacity and -50% left movement * Removed useless type checking * Fixed opacity * Opacity * Opacity flipped * Removed 0 * Reversed opacities * One more attempt * [PanelStack] merge some files (#2719) * merge PanelHeader into PanelView * panelProps file with more docs * panelProps.ts * export panelProps, more docs * example key * docs * safeInvoke * changed easing settings * fix copyrights * onClose/Open param names * [PanelStack] use IPanel in openPanel() public API (#2738) * openPanel accepts IPanel instead of three args * PanelView onClose/Open props skips getPanelProps() step * fix tests * remove IPanelPptions * [PanelStack] documentation (#2737) * PanelStack docs * more docs refactors * adjust docs-modifiers margins * remove "pop the stack"
* Adding border-radius inheritance to popover within control-group * Update comment to trigger build * Moving these rules to more logical place
* pages can define `tag: message` in metadata to appear next to nav item * mark some pages as new * remove intent import
* displayName Blueprint3 * new DISPLAYNAME_PREFIX constant, interpolate in every displayName * fix a few
* Popover add boundariesElement prop for easier modifiers * rename to boundary * rename type to PopperBoundary * fix examples
- @blueprintjs/[email protected] - @blueprintjs/[email protected] - @blueprintjs/[email protected] - @blueprintjs/[email protected]
* Fix change activeItem when query changes on props for QueryList * move willRecieveProps to componentDidUpdate * put back * fix import. VSCode - I ahte you
* fix Popover openOnTargetFocus tabIndex logic * refactor DateInput inputRef logic & add tests * fix import path * add corresponding InputGroup tests
* ref type | null
* remove <T> on react events
optional type!!
* Keys.isKeyboardClick
it's like a method on a java enum!
* total render refactor
- FIX: css class is applied when buttons=none
- renderButtons() and renderInput()
- conditionals to place buttons before or after input
- remove special-casing for buttons=none
* generate button event handlers, fix key holding
one little function to cache handler objects.
fix holding enter/space to continuously change value.
* onKeyUp handler is obsolete
Button handles enter/space click logic.
onKeyDown is actually enough - quite elegant.
* remove isButtonGroupFocused state
set but never read
* move shouldSelectAfterUpdate to state so it triggers updates
for the selection logic in cmpDidUpdate
* required state, missed a <T>
* update and refactor tests
not much needed here
* pull pure methods out to utils file
* fix tabs usage
* little things: public state, {value}
* orgainze
* missed a reset
* Remove unused styling in daterangepicker.scss * Configure CircleCI previews
* add safeInvokeMember util * add Popover targetProps, using new util for overridden events * tests * only one spread * add note about ref * add notes about types
* upgrade circle-github-bot * refactor script so it logs artifact URLs if auth token is missing
* add htmlTitle prop to Icon * try to kick circleci? * comment update & backticks * add "on hover"
* update contributing notes: DO NOT enable Circle for forks. * finish the sentence
…pdate (#3215) * [Popover] public reposition method to schedule popper update * add tooltip.reposition()
* Add failing tests * Use two DayPickers for contiguous months This is so that we can customize the behavior for captions, so the left caption changes the start month/year and the right caption changes the end. * Add additional rendering tests * Lint * Configure CircleCI previews * Add enforcement for contiguousMonth toggling
- @blueprintjs/[email protected] - @blueprintjs/[email protected] - @blueprintjs/[email protected] - @blueprintjs/[email protected]
React does not guarantee that the state changes are applied immediately. It is best practice to use an updater function if the new state relies on the current state.
* Add menu item label classname * Add text classname prop * Alphabetize props & improve docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.