Bump unpkg example to 3.0.0 #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @rgbkrk! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
giladgray
reviewed
Jul 15, 2018
| @@ -92,8 +92,8 @@ These bundles _do not include_ external dependencies; your application will need | |||
| <script src="https://unpkg.com/react-transition-group@^2.2.1/dist/react-transition-group.min.js"></script> | |||
| <script src="https://unpkg.com/popper.js@^1.12.6/dist/umd/popper.js"></script> | |||
| <script src="https://unpkg.com/react-popper@~0.7.4/dist/react-popper.min.js"></script> | |||
There was a problem hiding this comment.
popper.js and react-popper versions need to change too.
https://github.com/palantir/blueprint/blob/develop/packages/core/package.json#L46-L47
|
|
|
Tracing through the built dist, I'm seeing where Not real sure why that is. |
giladgray
suggested changes
Jul 16, 2018
| <script src="https://unpkg.com/@blueprintjs/core@^2.0.0"></script> | ||
| <script src="https://unpkg.com/@blueprintjs/icons@^2.0.0"></script> | ||
| <script src="https://unpkg.com/popper.js@^1.14.1/dist/umd/popper.js"></script> | ||
| <script src="https://unpkg.com/[email protected]/dist/index.umd.min.js"></script> |
|
@rgbkrk i don't see that error. is it still a problem on your end? |
giladgray
approved these changes
Jul 16, 2018
|
Yeah I took this example as part of a file called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copy pasted the unpkg css lines for blueprintjs while working with the 3.x release then finally noticed that the referenced css was the 2.x line. Not sure if the code snippet below this needs it.