[docs-theme] add Example forceUpdate prop to disable that behavior #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invliD
reviewed
Jul 16, 2018
| @@ -114,6 +121,9 @@ export class Example extends React.PureComponent<IDocsExampleProps> { | |||
| } | |||
|
|
|||
| public componentDidMount() { | |||
| if (this.props.forceUpdate === false) { | |||
There was a problem hiding this comment.
this is very unintuitive. What about using default props or destructuring with a default and if (!this.props.forceUpdate)?
invliD
approved these changes
Jul 23, 2018
| // `forceUpdate` - The docs app suffers from a Flash of Unstyled Content | ||
| // that causes components to mis-measure themselves on first render. | ||
| // Delay initial render till the DOM loads with a requestAnimationFrame. | ||
| const { forceUpdate = true } = this.props; |
There was a problem hiding this comment.
prefer having defaults in one place (defaultProps since you're using it twice)
Example defaultPropsPreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow disabling
forceUpdatebehavior inExampleframe as it interferes with non-React libraries.