Upgrade setup-node in actions #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
changed the title
mattseddon
commented
Sep 16, 2021
| id: yarn-cache-dir-path | ||
| run: echo "::set-output name=dir::$(yarn cache dir)" | ||
|
|
||
| - uses: actions/cache@v2 |
There was a problem hiding this comment.
[F] This step was taking up to 4m to run!
|
Code Climate has analyzed commit 8e4e78a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.1% (0.0% change). View more on Code Climate. |
mattseddon
commented
Sep 16, 2021
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
| key: yarn-${{ hashFiles('**/yarn.lock') }} | ||
| restore-keys: yarn | ||
| node-version: '14' |
There was a problem hiding this comment.
[Q] Any idea if we were running on 16 before?
There was a problem hiding this comment.
The action's docs say if node-version is omitted it'll run on the one on PATH, and this issue says GHA uses LTS by default, so if those are both true then we should've been on 14 already- explicitly specifying it is better, though.
rogermparent
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have experienced some pain working with our CI this week.
This PR reduces the number of actions that we have to run within the actions. Should reduce the runtime across each of the actions.... actions.