Split commands in tracked explorer tree between virtual and non-virtual paths #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Sep 16, 2021
| @@ -127,94 +127,6 @@ suite('Tracked Explorer Tree Test Suite', () => { | |||
| expect(window.activeTextEditor?.viewColumn).not.to.equal(ViewColumn.One) | |||
| }) | |||
|
|
|||
| it('should not fail to open a file to the side if it is not on disk', async () => { | |||
There was a problem hiding this comment.
[F] This code path no longer exists, if the file does not exist on disk then the command should not be shown.
mattseddon
commented
Sep 16, 2021
| @@ -280,12 +280,6 @@ | |||
| "description": "%config.pythonPath.description%", | |||
| "type": "string", | |||
| "default": null | |||
| }, | |||
| "dvc.views.trackedExplorerTree.noPromptPullMissing": { | |||
There was a problem hiding this comment.
[F] Another do not show again option that we no longer need
mattseddon
commented
Sep 16, 2021
|
|
||
| internalCommands.registerExternalCommand<string>( | ||
| RegisteredCommands.TRACKED_EXPLORER_OPEN_TO_THE_SIDE, | ||
| path => executeCommand('explorer.openToSide', path) |
There was a problem hiding this comment.
[F] We only reregister these so that we can get analytics for the actions.
rogermparent
approved these changes
Sep 16, 2021
|
Code Climate has analyzed commit d5a75c8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
master<- this <- #818This PR reworks the way that we display commands for files that are not on disk. Previously we showed all the commands and then had different code paths for if the file
!exists. This change eliminates those code paths by giving providing a different context in the tree. Should eliminate a source of bugs in the future and set us up for different actions for "virtual" files / folders.Demo:
Screen.Recording.2021-09-16.at.1.46.08.pm.mov