Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade setup-node in actions #817

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Upgrade setup-node in actions #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5a1a0f
move setup action after cache restoration
mattseddon Sep 16, 2021
13e030f
repeat move in cross platform tests
mattseddon Sep 16, 2021
8e4e78a
do not think you need the old action anymore
mattseddon Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,10 @@ jobs:
value: '{{ original }}-${{ github.sha }}'

- name: Setup Node.js environment
uses: actions/[email protected]

- name: Get Yarn cache path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"

- uses: actions/cache@v2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] This step was taking up to 4m to run!

name: Restore Yarn cache
id: yarn-cache
uses: actions/setup-node@v2
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: yarn
node-version: '14'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Any idea if we were running on 16 before?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action's docs say if node-version is omitted it'll run on the one on PATH, and this issue says GHA uses LTS by default, so if those are both true then we should've been on 14 already- explicitly specifying it is better, though.

cache: 'yarn'

- uses: actions/cache@v2
name: Restore NYC cache
Expand Down
15 changes: 3 additions & 12 deletions .github/workflows/cross-platform-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,10 @@ jobs:
fetch-depth: 0

- name: Setup Node.js environment
uses: actions/[email protected]

- name: Get Yarn cache path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"

- uses: actions/cache@v2
name: Restore Yarn cache
id: yarn-cache
uses: actions/setup-node@v2
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: yarn-${{ hashFiles('**/yarn.lock') }}-${{ matrix.os }}
restore-keys: yarn
node-version: '14'
cache: yarn

- uses: actions/cache@v2
name: Restore .vscode-test cache
Expand Down