Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref/remote: tabify & crossref config #3299

Closed
wants to merge 1 commit into from
Closed

Conversation

- related #2939
- related #1859
- related #2866
- related #1699
@casperdcl casperdcl added A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference labels Feb 18, 2022
@casperdcl casperdcl requested review from shcheklein and a team February 18, 2022 20:22
@casperdcl casperdcl self-assigned this Feb 18, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-tab-remote-conf-kfckwc February 18, 2022 20:23 Inactive
@shcheklein
Copy link
Member

A few concerns (mainly that it doesn't change much and doesn't solve the problem):

  • it's still not exactly linkable (you are sending link to a subsection still at best). I'm not sure this changes experience much - when open the subsection you see all the titles in one page now
  • long term it should be addresses in some other epics where we want to get it out into separate pages. Clearly content is too large for tabs, subsections, and hidden sections
  • I personally don't like that by default now it'a a huge long S3 section that is visible. Not sure this is the best experience.

@casperdcl
Copy link
Contributor Author

I 💯 agree it doesn't solve the problem. However it solves a problem to me.

when open the subsection you see all the titles in one page now

I suppose that's a separate A: website issue?

default now it'a a huge long S3 section

We could reorder to have a shorter default?

@shcheklein
Copy link
Member

However it solves a problem to me.

I assume ability to link to a specific section? Fair enough, but let's do it quick - just move all into section or make expandable blocks linkable - I think it should not be a problem and we could do it quick cc @iterative/websites

I suppose that's a separate A: website issue?

What I wanted to say is that current experience (link - https://dvc.org/doc/command-reference/remote/modify#available-parameters-per-storage-type) gives you very similar experience (or I don't understand a problem):

Screen Shot 2022-02-18 at 7 05 59 PM

I see all the available options there.

Or do you mean something else?

We could reorder to have a shorter default?

Not good I guess, since S3 is the default these days

WDYT?

@casperdcl
Copy link
Contributor Author

move all into section

not sure what this means; sounds like #2866 and/or #1699

or make expandable blocks linkable

sure, that sounds good to me.

@jorgeorpinel
Copy link
Contributor

So does #3314 solve this?

@casperdcl
Copy link
Contributor Author

So does #3314 solve this?

Partially. Would probably still have to delete "Click for " prefixes.

@casperdcl
Copy link
Contributor Author

replaced by #3329

@casperdcl casperdcl closed this Mar 24, 2022
@casperdcl casperdcl deleted the tab-remote-config branch March 24, 2022 20:36
casperdcl added a commit that referenced this pull request Mar 24, 2022
shcheklein pushed a commit that referenced this pull request Mar 29, 2022
iesahin pushed a commit that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants