Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup remote block headings #3391

Merged
merged 1 commit into from
Mar 29, 2022
Merged

cleanup remote block headings #3391

merged 1 commit into from
Mar 29, 2022

Conversation

casperdcl
Copy link
Contributor

Details blocks are #id linkable now (#3329) so should have URL-friendly names

@casperdcl casperdcl added the A: docs Area: user documentation (gatsby-theme-iterative) label Mar 24, 2022
@casperdcl casperdcl self-assigned this Mar 24, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-remote-details-sw4ehz0 March 24, 2022 20:45 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure why not, looks better. Thanks!

@shcheklein shcheklein merged commit 3069f77 into master Mar 29, 2022
@shcheklein shcheklein deleted the remote-details branch March 29, 2022 05:04
@@ -165,7 +165,7 @@ $ dvc get-url webhdfs://[email protected]/path/to/file

<details>

### Click and expand for a local example
### local
Copy link
Contributor

@jorgeorpinel jorgeorpinel Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. Should be "Local" or something like "Local system path".

### Click for local remote
### local remote
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

### Click for local file system paths
### local file system paths
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's closer.

### Click for local file system paths
### local file system paths
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@jorgeorpinel

This comment was marked as outdated.

iesahin pushed a commit that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants