Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: extract remote add/modify (advanced) config details to UG #1859

Closed
2 tasks done
skshetry opened this issue Oct 13, 2020 · 17 comments
Closed
2 tasks done

guide: extract remote add/modify (advanced) config details to UG #1859

skshetry opened this issue Oct 13, 2020 · 17 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement good first issue Good for newcomers p1-important Active priorities to deal within next sprints

Comments

@skshetry
Copy link
Member

skshetry commented Oct 13, 2020

UPDATE: Jump to #1859 (comment)

UPDATE 2: Some related tickets that could potentially be included in this refactor:


It'd be great if we could share the link to that container directly (that on opening would expand the container and scroll that touser's viewport).

eg: The following section on command-reference/run#description.
Capture

@skshetry skshetry changed the title way to link directly to the collapsible container a way to link directly to the collapsible container Oct 13, 2020
@jorgeorpinel jorgeorpinel added website: eng-doc DEPRECATED JS engine for /doc type: feature-request DEPRECATED New feature or request labels Oct 13, 2020
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 13, 2020

Would be nice to have. Probably not very hard to implement either but I'm not convinced there's a huge need. We indeed already have a bit of a problem of linking to anchors too much — it's best to avoid that as headers tend to change which causes semi-broken links which are very hard to detect.

@jorgeorpinel jorgeorpinel added hacktoberfest help wanted Contributors especially welcome labels Oct 13, 2020
@shcheklein
Copy link
Member

My take on this- if it happens with a certain section then it probably means that the section should not be collapsible- rather regular section, like the one @skshetry mentioned. In a lot of cases we use collapsible sections as a substitute for the whole page (e.g. remotes).

@jorgeorpinel
Copy link
Contributor

Good point. So should we change this to reviewing the existing <details> sections? E.g. are you saying we should use regular H3 sections in remote add and modify @shcheklein ?

@jorgeorpinel jorgeorpinel removed website: eng-doc DEPRECATED JS engine for /doc hacktoberfest help wanted Contributors especially welcome labels Oct 13, 2020
@shcheklein
Copy link
Member

So should we change this to reviewing the existing

sections?

let's do this as we go, care by case

E.g. are you saying we should use regular H3 sections in remote add and modify @shcheklein ?

yes, if there is a feeling that we want to share a link, or that information is important enough, not auxiliary

@jorgeorpinel
Copy link
Contributor

do this as we go

Got it. So, close this issue (as not actionable)

that information is important enough, not auxiliary

In the case of remote add/modify examples the usage of the details sections is not to include auxiliary info but simply to make the docs more compact. They would be really really long otherwise. The other approach would be to break up the doc into several pages but it's not clear to me how (without new engine features).

@shcheklein
Copy link
Member

Got it. So, close this issue (as not actionable)

why? we can make specifically this section H3?

The other approach would be to break up the doc into several pages but it's not clear to me how (without new engine features).

just break like we do for Google Drive (to some extent)? Just create separate pages and link them from those small collapsibles ?

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 14, 2020

can make specifically this section H3

I think that was just a generic example. Or are we trying to actually link to Avoiding unexpected behavior in https://dvc.org/doc/command-reference/run#description from somewhere @skshetry ?

Just create separate pages

Unlisted pages? (not in nav) Yeah that could work, it's just not something we do much currently.

@shcheklein
Copy link
Member

Unlisted pages? (not in nav) Yeah that could work, it's just not something we do much currently.

no, I mean regular page. We should not be doing unlisted pages (why?). Similar to GDrive.

@jorgeorpinel
Copy link
Contributor

break like we do for Google Drive
I mean regular page

OK so a single guide specifically for remote add/modify configuration... OK, that should work, repurposing issue!

@shcheklein
Copy link
Member

OK, that should work, repurposing issue!

I think, let's wait on @skshetry .. it might be he wanted to share this specific link

@jorgeorpinel jorgeorpinel changed the title a way to link directly to the collapsible container remote: extract add/modify (advanced) configuration details to a separate guide Oct 14, 2020
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) good first issue Good for newcomers hacktoberfest and removed type: feature-request DEPRECATED New feature or request labels Oct 14, 2020
@jorgeorpinel jorgeorpinel added p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. and removed hacktoberfest labels Apr 22, 2021
@jorgeorpinel jorgeorpinel changed the title remote: extract add/modify (advanced) configuration details to a separate guide guide: extract remote add/modify (advanced) config details to UG Jul 19, 2021
@jorgeorpinel
Copy link
Contributor

A good first attempt (specific to Azure): #2634

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel added the ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement label Aug 25, 2021
@casperdcl

This comment has been minimized.

@daavoo
Copy link
Contributor

daavoo commented Sep 16, 2021

A good first attempt (specific to Azure): #2634

Another user has created something that could be part of a Setup a Microsoft Azure DVC Remote guide:

iterative/dvc#2200 (comment)

@jorgeorpinel jorgeorpinel added p1-important Active priorities to deal within next sprints and removed p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. labels Sep 27, 2021
@shcheklein
Copy link
Member

I think we have prematurely renamed this issue. This was not about remotes, it was about run?

@jorgeorpinel
Copy link
Contributor

Hmm yeah I probably didn't notice your message in #1859 (comment) and then @skshetry never followed up so this issue was repurposed. I believe he meant this as a general feature though, either for that run ref example or other places... I guess I should reopen both that issue and the one about moving remote ref details to the UG ⏳

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Sep 29, 2021

See #2865
and #2866

@iesahin iesahin added the C: guide Content of /doc/user-guide label Oct 21, 2021
casperdcl added a commit that referenced this issue Feb 18, 2022
- related #2939
- related #1859
- related #2866
- related #1699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement good first issue Good for newcomers p1-important Active priorities to deal within next sprints
Projects
None yet
Development

No branches or pull requests

6 participants